Add --stop-after argument to dora run
#1308
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for example useful for running examples on CI that never finish on their own.
Collaborator
Author
|
Adding the new argument requires adjustments on all caller sites. Instead, we could add a new |
Collaborator
|
Should we try to have a builder pattern for rust so that we can add arguments later without having to modify everything every time? Same for uv and build? |
haixuanTao
approved these changes
Jan 21, 2026
Collaborator
haixuanTao
left a comment
haixuanTao
left a comment
There was a problem hiding this comment.
Should we try to have a builder pattern for rust so that we can add arguments later without having to modify everything every time? Same for uv and build?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for example useful for running examples on CI that never finish on their own.