fix(examples): add missing Windows linker flags for C++ example #1311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dora-rs#1105 - Add oleaut32 library for COM error handling (GetErrorInfo/SetErrorInfo) - Configure operators to use dynamic runtime to match Rust - Remove conflicting static runtime flag - Update README with complete Windows linker flags The example already had Windows-specific compiler flags, but was missing oleaut32 (needed by the windows crate for COM error handling) and proper runtime library configuration. This caused LNK2019 and LNK2038 errors. Tested on Windows 11 with clang++. All C++ nodes and operators now compile and link successfully.
Collaborator
|
Previous PR: #1300 |
Collaborator
|
Seems to have a similar CI error as #1300. Does it work for you locally? |
Author
|
Yes it's working locally ,I think it's the runtime intialization issue as i have tested all c++ files are compiling and running locally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1105
The previous failure was due to a linker issue during execution. This has now been fixed, and the example compiles and runs successfully on my local machine.