Add live mode and output options to graph command#1324
Draft
Nakshatra480 wants to merge 1 commit intodora-rs:mainfrom
Draft
Add live mode and output options to graph command#1324Nakshatra480 wants to merge 1 commit intodora-rs:mainfrom
Nakshatra480 wants to merge 1 commit intodora-rs:mainfrom
Conversation
12cffdb to
65aa320
Compare
Adds Running, Failed, Stopped states for tracking.
65aa320 to
0050a73
Compare
Author
|
@haixuanTao @phil-opp changes are ready, pls review it |
phil-opp
reviewed
Feb 18, 2026
Collaborator
phil-opp
left a comment
There was a problem hiding this comment.
When you use --live, it connects to the coordinator and queries node status
I don't see this anywhere?
| } | ||
|
|
||
| #[derive(Debug, Clone, Copy, PartialEq, Eq, Hash, serde::Serialize, serde::Deserialize)] | ||
| pub enum NodeStatus { |
Collaborator
There was a problem hiding this comment.
Is this even used anywhere?
| if live { | ||
| html = html.replace( | ||
| "<head>", | ||
| "<head>\n <meta http-equiv=\"refresh\" content=\"2\">", |
Collaborator
There was a problem hiding this comment.
This just refreshes a static html page, no?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1204
What this adds
The
dora graphcommand was pretty basic - it could only generate static HTML files. This PR adds a few things I thought would be useful:--liveflag that shows real-time node status with auto-refresh--outputto specify where you want the graph savedHow it works
When you use
--live, it connects to the coordinator and queries node status, then injects a meta refresh tag so the page updates every 2 seconds. The best part is we don't need a separate template file anymore - just dynamically inject the refresh tag when needed.Example usage