feat(cli): add dora system start and dora system stop commands#1350
Open
swar09 wants to merge 3 commits intodora-rs:mainfrom
Open
feat(cli): add dora system start and dora system stop commands#1350swar09 wants to merge 3 commits intodora-rs:mainfrom
swar09 wants to merge 3 commits intodora-rs:mainfrom
Conversation
Collaborator
|
Thanks for the PR! @ZhangHanDong Is this what you had in mind when opening #1206 and #1207? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1206, closes #1207
This PR adds dora system start and dora system stop commands to replace dora up and dora destroy.
The logic has been moved into the system subcommand group, which already has dora system status.
dora system startdoes the same thing asdora updora system stopstops any running dataflows (asks for confirmation) we can use--forceor-fto skip the confirmationdora up&dora destroy(kept as an alias)