[Blazor] webassembly-lazy-load-assemblies.md - Forms package already referenced #34242
Conversation
guardrex
left a comment
guardrex
left a comment
There was a problem hiding this comment.
See if my suggestion makes sense. I agree that the text is wrong, but a replacement could meet the original goal of making it clear what packages are important here.
| * Visual Studio: Right-click the solution file in **Solution Explorer** and select **Add** > **New project**. From the dialog of new project types, select **Razor Class Library**. Name the project `GrantImaharaRobotControls`. Do **not** select the **Support pages and view** checkbox. | ||
| * Visual Studio Code/.NET CLI: Execute `dotnet new razorclasslib -o GrantImaharaRobotControls` from a command prompt. The `-o|--output` option creates a folder and names the project `GrantImaharaRobotControls`. | ||
|
|
||
| The example component presented later in this section uses a [Blazor form](xref:blazor/forms/index). In the RCL project, add the [`Microsoft.AspNetCore.Components.Forms`](https://www.nuget.org/packages/Microsoft.AspNetCore.Components.Forms) package to the project. |
There was a problem hiding this comment.
It might be better to state what's going on with the packages here. This could say something like ...
The example component presented later in this section uses a [Blazor form](xref:blazor/forms/index). Because the RCL was created without supporting pages and views, the RCL includes a package reference for [`Microsoft.AspNetCore.Components.Web`](https://www.nuget.org/packages/Microsoft.AspNetCore.Components.Web), which transitivity includes the [`Microsoft.AspNetCore.Components.Forms`](https://www.nuget.org/packages/Microsoft.AspNetCore.Components.Forms) package.
[!INCLUDE[](~/includes/package-reference.md)]
There was a problem hiding this comment.
If you create the RCL with "Support pages and view" checked, the new project still successfully compiles the Robot.razor component (with <EditForm> and <InputRadioGroup>), most likely because of <FrameworkReference Include="Microsoft.AspNetCore.App" />.
Why do you think we need to include package-related info in the article?
There was a problem hiding this comment.
Truly, it was just a passing concern. I didn't know what would happen in that configuration. Let's go ahead with your suggestion.
Co-authored-by: Luke Latham <[email protected]>
guardrex
left a comment
guardrex
left a comment
There was a problem hiding this comment.
Thanks for fixing this! 🎉
2 participants
The
Microsoft.AspNetCore.Components.Formspackage is already transitively referenced byMicrosoft.AspNetCore.Components.Webpackage (which is included in the RCL template). No need to add explicit reference toFormspackage.Internal previews