Skip to content

[Blazor] webassembly-lazy-load-assemblies.md - Forms package already referenced #34242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guardrex merged 2 commits into from
Dec 1, 2024
Merged

[Blazor] webassembly-lazy-load-assemblies.md - Forms package already referenced #34242

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f96063
[Blazor] webassembly-lazy-load-assemblies.md - Forms package already …
hakenr Nov 29, 2024
e2a24fd
Update aspnetcore/blazor/webassembly-lazy-load-assemblies.md
hakenr Dec 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions aspnetcore/blazor/webassembly-lazy-load-assemblies.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,10 +339,6 @@ Add an ASP.NET Core class library project to the solution:
* Visual Studio: Right-click the solution file in **Solution Explorer** and select **Add** > **New project**. From the dialog of new project types, select **Razor Class Library**. Name the project `GrantImaharaRobotControls`. Do **not** select the **Support pages and view** checkbox.
* Visual Studio Code/.NET CLI: Execute `dotnet new razorclasslib -o GrantImaharaRobotControls` from a command prompt. The `-o|--output` option creates a folder and names the project `GrantImaharaRobotControls`.

The example component presented later in this section uses a [Blazor form](xref:blazor/forms/index). In the RCL project, add the [`Microsoft.AspNetCore.Components.Forms`](https://www.nuget.org/packages/Microsoft.AspNetCore.Components.Forms) package to the project.
Copy link
Collaborator

@guardrex guardrex Dec 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be better to state what's going on with the packages here. This could say something like ...

The example component presented later in this section uses a [Blazor form](xref:blazor/forms/index). Because the RCL was created without supporting pages and views, the RCL includes a package reference for [`Microsoft.AspNetCore.Components.Web`](https://www.nuget.org/packages/Microsoft.AspNetCore.Components.Web), which transitivity includes the [`Microsoft.AspNetCore.Components.Forms`](https://www.nuget.org/packages/Microsoft.AspNetCore.Components.Forms) package.

[!INCLUDE[](~/includes/package-reference.md)]

Copy link
Member Author

@hakenr hakenr Dec 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you create the RCL with "Support pages and view" checked, the new project still successfully compiles the Robot.razor component (with <EditForm> and <InputRadioGroup>), most likely because of <FrameworkReference Include="Microsoft.AspNetCore.App" />.

Why do you think we need to include package-related info in the article?

Copy link
Collaborator

@guardrex guardrex Dec 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Truly, it was just a passing concern. I didn't know what would happen in that configuration. Let's go ahead with your suggestion.


[!INCLUDE[](~/includes/package-reference.md)]

Create a `HandGesture` class in the RCL with a `ThumbUp` method that hypothetically makes a robot perform a thumbs-up gesture. The method accepts an argument for the axis, `Left` or `Right`, as an [`enum`](/dotnet/csharp/language-reference/builtin-types/enum). The method returns `true` on success.

`HandGesture.cs`:
Expand Down