Some minor fixes before new version release #2686
Merged
+19
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e into account _s in net10.0 and beyond enum names, and updated the ConfigParserTests to take this update into account.
… old version of System.Collections.Immutable
timcassell
approved these changes
Jan 7, 2025
timcassell
reviewed
Jan 20, 2025
| <TreatWarningsAsErrors>true</TreatWarningsAsErrors> | ||
|
|
||
| <Nullable>annotations</Nullable> | ||
| <!-- Lets supress the "System.Collections.Immutable 8.0.0 doesn't support netcoreapp3.1" warning --> |
Collaborator
There was a problem hiding this comment.
Interesting, I wonder if that works for netcoreapp2.0, and if we could revert #2505.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of:
@timcassell I saw your comment here:
BenchmarkDotNet/src/BenchmarkDotNet/BenchmarkDotNet.csproj
Lines 25 to 27 in 3337a09
And tested the netcoreapp3.1 support with my changes:
It works: