Optimize ToFlatOpcString to reduce memory usage and improve performan…#1863
Merged
mikeebowen merged 2 commits intodotnet:mainfrom Feb 4, 2025
Merged
Conversation
…ce by removing excessive LINQ operations and intermediate collections. Simplify Base64 string chunking using Convert.ToBase64String with InsertLineBreaks, eliminating manual chunking and aligning with MIME specifications.
Contributor
Author
|
@dotnet-policy-service agree |
twsouthwick
approved these changes
Feb 4, 2025
Member
twsouthwick
left a comment
twsouthwick
left a comment
There was a problem hiding this comment.
This is great! I had wanted to optimize this area figuring it was not performant, but didn't know about that enum option. Thanks!
mikeebowen
approved these changes
Feb 4, 2025
Contributor
Author
|
Thanks @twsouthwick and @mikeebowen! |
Member
|
This is included in 3.3.0! |
Contributor
Author
|
Thank @twsouthwick :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimized the ToFlatOpcString method to address high memory usage and improve performance.
The previous implementation relied on LINQ, which created a significant amount of intermediate collections and dictionaries, leading to inefficiency, especially when working with Word documents containing images.
This update removes unnecessary LINQ operations and reduces memory overhead, replace manual chunking logic with Convert.ToBase64String using Base64FormattingOptions.InsertLineBreaks.
This approach eliminates the need for LINQ-based chunking and aggregation, resulting in cleaner, more efficient code while adhering to the MIME specification for line breaks in Base64 encoding.
A sample benchmark output when working with a 822KB-word document.