Skip to content

Optimize ToFlatOpcString to reduce memory usage and improve performan… #1863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikeebowen merged 2 commits into from
Feb 4, 2025
Merged

Optimize ToFlatOpcString to reduce memory usage and improve performan… #1863

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
980c4f3
Optimize ToFlatOpcString to reduce memory usage and improve performan…
DatHoang83 Jan 24, 2025
570aae7
Merge branch 'main' into flatopc-extensions/fix-high-memory-usage
twsouthwick Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 1 addition & 19 deletions src/DocumentFormat.OpenXml.Framework/Packaging/FlatOpcExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,25 +141,7 @@ private static string ToChunkedBase64String(IPackagePart part)
}

private static string ToChunkedBase64String(byte[] byteArray)
{
// The MIME specification defines a maximum line length of 76 characters
// for a Base64-encoded string. Therefore, we need to break down the
// Base64 string into chunks of up to 76 characters each.
const int maxLineLength = 76;

return Convert.ToBase64String(byteArray)
.Select((@char, index) => new { Character = @char, Chunk = index / maxLineLength })
.GroupBy(charAndChunk => charAndChunk.Chunk)
.Aggregate(
new StringBuilder(),
(sb, grouping) => sb
.Append(grouping.Aggregate(
new StringBuilder(),
(chunkSb, charAndChunk) => chunkSb.Append(charAndChunk.Character),
chunkSb => chunkSb.ToString()))
.Append(Environment.NewLine),
sb => sb.ToString());
}
=> Convert.ToBase64String(byteArray, Base64FormattingOptions.InsertLineBreaks);

internal static IPackageFactory<TPackage> WithFlatOpcTemplate<TPackage>(this IPackageFactory<TPackage> builder, string text, bool? isEditable = default)
where TPackage : OpenXmlPackage
Expand Down
Loading