-
Notifications
You must be signed in to change notification settings - Fork 315
Tests | Active Issues (Part 2) #3624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR re-enables two certificate-related manual tests that were previously disabled due to an active issue. The changes modify how admin privilege requirements are handled and make the entire test class Windows-specific.
Key Changes:
- Re-enabled
OpeningConnectionWithGoodCertificateTest
andOpeningConnectionWithNicTest
by removing[ActiveIssue("31754")]
attributes - Changed admin privilege handling from assertion to test skipping using conditional facts
- Applied
[PlatformSpecific(TestPlatforms.Windows)]
at the class level instead of individual test methods
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ConnectionTestWithSSLCert/CertificateTest.cs
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ConnectionTestWithSSLCert/CertificateTest.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we run any stages as admin? Or will these still be skipped in the pipeline?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3624 +/- ##
==========================================
+ Coverage 67.94% 69.87% +1.92%
==========================================
Files 276 276
Lines 61641 61674 +33
==========================================
+ Hits 41885 43093 +1208
+ Misses 19756 18581 -1175
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
This is a continuation of submitting the individual active issue re-enables from #3304. This submission re-enables 2 tests and changes how they're included slightly:
Tests Enabled:
Other Changes:
Issues
31754, which belongs to some ticketing system forgotten to time
Testing
Tests build and are successfully skipped if not ran in Admin mode. CI should validate it further.