Skip to content

Conversation

benrr101
Copy link
Contributor

Description

This is a continuation of submitting the individual active issue re-enables from #3304. This submission re-enables 2 tests and changes how they're included slightly:

Tests Enabled:

  • ManualTests - CertificateTest.OpeningConnectionWithGoodCertificateTest
  • ManualTests - CertificateTest.OpeningConnectionWithNicTest

Other Changes:

  • Rather than Assert.True the tests are ran as Admin, the tests are now skipped if not executed in Admin mode
  • Making the entire class platform-specific to Windows rather than individual tests

Issues

31754, which belongs to some ticketing system forgotten to time

Testing

Tests build and are successfully skipped if not ran in Admin mode. CI should validate it further.

@benrr101 benrr101 added this to the 7.0-preview2 milestone Sep 22, 2025
@benrr101 benrr101 added the Area\Tests Issues that are targeted to tests or test projects label Sep 22, 2025
@benrr101 benrr101 requested a review from a team as a code owner September 22, 2025 22:38
@Copilot Copilot AI review requested due to automatic review settings September 22, 2025 22:38
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR re-enables two certificate-related manual tests that were previously disabled due to an active issue. The changes modify how admin privilege requirements are handled and make the entire test class Windows-specific.

Key Changes:

  • Re-enabled OpeningConnectionWithGoodCertificateTest and OpeningConnectionWithNicTest by removing [ActiveIssue("31754")] attributes
  • Changed admin privilege handling from assertion to test skipping using conditional facts
  • Applied [PlatformSpecific(TestPlatforms.Windows)] at the class level instead of individual test methods

Copy link
Contributor

@mdaigle mdaigle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we run any stages as admin? Or will these still be skipped in the pipeline?

@mdaigle mdaigle self-assigned this Sep 22, 2025
Copy link

codecov bot commented Sep 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.87%. Comparing base (2655083) to head (71364e3).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3624      +/-   ##
==========================================
+ Coverage   67.94%   69.87%   +1.92%     
==========================================
  Files         276      276              
  Lines       61641    61674      +33     
==========================================
+ Hits        41885    43093    +1208     
+ Misses      19756    18581    -1175     
Flag Coverage Δ
addons 90.82% <ø> (ø)
netcore 73.79% <ø> (+3.92%) ⬆️
netfx 68.86% <ø> (-1.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@paulmedynski paulmedynski self-assigned this Sep 23, 2025
@benrr101 benrr101 merged commit d2be2be into main Sep 25, 2025
252 checks passed
@benrr101 benrr101 deleted the dev/russellben/active-issues2 branch September 25, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area\Tests Issues that are targeted to tests or test projects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants