Skip to content

Tests | Active Issues (Part 2) #3624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2025
Merged

Tests | Active Issues (Part 2) #3624

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b12dea9
Reactivate: OpeningConnectionWithGoodCertificateTest, OpeningConnecti…
benrr101 Sep 22, 2025
71364e3
Fix name
benrr101 Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 14 additions & 16 deletions ...crosoft.Data.SqlClient/tests/ManualTests/SQL/ConnectionTestWithSSLCert/CertificateTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

namespace Microsoft.Data.SqlClient.ManualTesting.Tests
{
[PlatformSpecific(TestPlatforms.Windows)]
public class CertificateTest : IDisposable
{
#region Private Fields
Expand Down Expand Up @@ -75,10 +76,11 @@ public CertificateTest()
SlashInstanceName = $"\\{InstanceName}";
}

Assert.True(DataTestUtility.IsAdmin, "CertificateTest class needs to be run in Admin mode.");

CreateValidCertificate(s_fullPathToPowershellScript);
_thumbprint = Environment.GetEnvironmentVariable(ThumbPrintEnvName, EnvironmentVariableTarget.Machine);
if (IsAdmin())
{
CreateValidCertificate(s_fullPathToPowershellScript);
_thumbprint = Environment.GetEnvironmentVariable(ThumbPrintEnvName, EnvironmentVariableTarget.Machine);
}
}

private static bool IsLocalHost()
Expand All @@ -89,19 +91,18 @@ private static bool IsLocalHost()
}

private static bool AreConnStringsSetup() => DataTestUtility.AreConnStringsSetup();
private static bool IsAdmin() => DataTestUtility.IsAdmin;
private static bool IsNotAzureServer() => DataTestUtility.IsNotAzureServer();
private static bool UseManagedSNIOnWindows() => DataTestUtility.UseManagedSNIOnWindows;

[ActiveIssue("31754")]
[ConditionalFact(nameof(AreConnStringsSetup), nameof(IsNotAzureServer), nameof(IsLocalHost))]
[PlatformSpecific(TestPlatforms.Windows)]
public void OpenningConnectionWithGoodCertificateTest()
[ConditionalFact(nameof(AreConnStringsSetup), nameof(IsNotAzureServer), nameof(IsLocalHost), nameof(IsAdmin))]
public void OpeningConnectionWithGoodCertificateTest()
{
SqlConnectionStringBuilder builder = new(DataTestUtility.TCPConnectionString);

// confirm that ForceEncryption is enabled
using SqlConnection notEncryptedConnection = new(builder.ConnectionString);
builder.Encrypt = SqlConnectionEncryptOption.Optional;
using SqlConnection notEncryptedConnection = new(builder.ConnectionString);
notEncryptedConnection.Open();
Assert.Equal(ConnectionState.Open, notEncryptedConnection.State);

Expand All @@ -122,10 +123,8 @@ public void OpenningConnectionWithGoodCertificateTest()

// Provided hostname in certificate are:
// localhost, FQDN, Loopback IPv4: 127.0.0.1, IPv6: ::1
[ActiveIssue("31754")]
[ConditionalFact(nameof(AreConnStringsSetup), nameof(IsNotAzureServer), nameof(IsLocalHost))]
[PlatformSpecific(TestPlatforms.Windows)]
public void OpeningConnectionWitHNICTest()
[ConditionalFact(nameof(AreConnStringsSetup), nameof(IsNotAzureServer), nameof(IsLocalHost), nameof(IsAdmin))]
public void OpeningConnectionWithNicTest()
{
// Mandatory
SqlConnectionStringBuilder builder = new(DataTestUtility.TCPConnectionString)
Expand All @@ -143,7 +142,7 @@ public void OpeningConnectionWitHNICTest()
Assert.Equal(ConnectionState.Open, connection.State);

// Ipv6 however causes name mistmatch error
// In net6 Manged SNI does not check for SAN. Therefore Application using Net6 have to use FQDN as HNIC
// In net6 Manged SNI does not check for SAN. Therefore, Application using Net6 have to use FQDN as HNIC
// According to above no other hostname in certificate than FQDN will work in net6 which is same as SubjectName in case of RemoteCertificateNameMismatch
// Net7.0 the new API added by dotnet runtime will check SANS and then SubjectName

Expand All @@ -166,8 +165,7 @@ public void OpeningConnectionWitHNICTest()
}
}

[ConditionalFact(nameof(AreConnStringsSetup), nameof(UseManagedSNIOnWindows), nameof(IsNotAzureServer), nameof(IsLocalHost))]
[PlatformSpecific(TestPlatforms.Windows)]
[ConditionalFact(nameof(AreConnStringsSetup), nameof(UseManagedSNIOnWindows), nameof(IsNotAzureServer), nameof(IsLocalHost), nameof(IsAdmin))]
public void RemoteCertificateNameMismatchErrorTest()
{
SqlConnectionStringBuilder builder = new(DataTestUtility.TCPConnectionString)
Expand Down
Loading