Added TitleBar and Explorer tooltips #53
Conversation
michael-hawker
left a comment
michael-hawker
left a comment
There was a problem hiding this comment.
Thanks @Avid29! It's these little things that get overlooked sometimes, so appreciate the assist. 🦙❤️
Let me know if you're good to look at the suggestions here, otherwise can merge this as-is for now and update later too.
| Style="{ThemeResource BodyTextBlockStyle}" | ||
| Text="{x:Bind ((storage:StorageFile)Content).Name}" /> | ||
| Text="{x:Bind ((storage:StorageFile)Content).Name}" | ||
| ToolTipService.ToolTip="{x:Bind ((storage:StorageFile)Content).Name}" /> |
There was a problem hiding this comment.
For the Tooltip version, should we grab the fullpath along with this so that you can distinguish two files with the same name in different directories?
There was a problem hiding this comment.
This line specifically is in the work space tree view and should have no such confusion. Line 158 could use it though
There was a problem hiding this comment.
Ah, yes, good point. I wasn't noticing where it was in the relation to the whole context. Thanks for redirecting my comment's intent to the right location. 🙂
I'll pull this down later and then get it merged in. I also forgot I hadn't setup a CI yet. I'll have to get on that later this week. 😅
| <FontIcon Margin="-12,0,8,0" | ||
| FontFamily="{ThemeResource SymbolThemeFontFamily}" | ||
| Glyph="" /> | ||
| <TextBlock HorizontalAlignment="Left" |
There was a problem hiding this comment.
For the TextBlock ones, should we also add TextTrimming so that the filename is truncated more nicely?
Your comments just look like more good little things that I overlooked. I'll quickly tack them on and then it should be ready to merge! 😊 |
|
Here's the changed in that new PR: TabView and open editors got TextTrimming: Full path in tooltop in open editors and TabView: I did not add full path tooltips to the WorkSpace Folder since the folder is explicit |
2 participants
Fixes #31
PR Type
What kind of change does this PR introduce?
Other... Please describe:
What is the current behavior?
Long filenames get cutoff
What is the new behavior?
Hovering a tab item or an explorer item with a long name will reveal a tooltip
PR Checklist
Please check if your PR fulfills the following requirements:
Other information