-
Notifications
You must be signed in to change notification settings - Fork 30
Added TitleBar and Explorer tooltips #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,7 +31,8 @@ | |
| <TextBlock HorizontalAlignment="Left" | ||
| VerticalAlignment="Center" | ||
| Style="{ThemeResource BodyTextBlockStyle}" | ||
| Text="{x:Bind ((storage:StorageFile)Content).Name}" /> | ||
| Text="{x:Bind ((storage:StorageFile)Content).Name}" | ||
| ToolTipService.ToolTip="{x:Bind ((storage:StorageFile)Content).Name}" /> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For the Tooltip version, should we grab the fullpath along with this so that you can distinguish two files with the same name in different directories?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This line specifically is in the work space tree view and should have no such confusion. Line 158 could use it though
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah, yes, good point. I wasn't noticing where it was in the relation to the whole context. Thanks for redirecting my comment's intent to the right location. 🙂 I'll pull this down later and then get it merged in. I also forgot I hadn't setup a CI yet. I'll have to get on that later this week. 😅 |
||
| </StackPanel> | ||
| </DataTemplate> | ||
|
|
||
|
|
@@ -43,7 +44,8 @@ | |
| <TextBlock HorizontalAlignment="Left" | ||
| VerticalAlignment="Center" | ||
| Style="{ThemeResource BodyTextBlockStyle}" | ||
| Text="{x:Bind ((storage:StorageFile)Content).Name}" /> | ||
| Text="{x:Bind ((storage:StorageFile)Content).Name}" | ||
| ToolTipService.ToolTip="{x:Bind ((storage:StorageFile)Content).Name}" /> | ||
| </StackPanel> | ||
| </DataTemplate> | ||
|
|
||
|
|
@@ -55,7 +57,8 @@ | |
| <TextBlock HorizontalAlignment="Left" | ||
| VerticalAlignment="Center" | ||
| Style="{ThemeResource BodyTextBlockStyle}" | ||
| Text="{x:Bind ((storage:StorageFile)Content).Name}" /> | ||
| Text="{x:Bind ((storage:StorageFile)Content).Name}" | ||
| ToolTipService.ToolTip="{x:Bind ((storage:StorageFile)Content).Name}" /> | ||
| <!-- Show Hover Preview of Image --> | ||
| <ToolTipService.ToolTip> | ||
| <Image Width="128" | ||
|
|
@@ -74,7 +77,8 @@ | |
| <TextBlock HorizontalAlignment="Left" | ||
| VerticalAlignment="Center" | ||
| Style="{ThemeResource BodyTextBlockStyle}" | ||
| Text="{x:Bind ((storage:StorageFile)Content).Name}" /> | ||
| Text="{x:Bind ((storage:StorageFile)Content).Name}" | ||
| ToolTipService.ToolTip="{x:Bind ((storage:StorageFile)Content).Name}" /> | ||
| </StackPanel> | ||
| </DataTemplate> | ||
|
|
||
|
|
@@ -84,7 +88,8 @@ | |
| <TextBlock HorizontalAlignment="Left" | ||
| VerticalAlignment="Center" | ||
| Style="{ThemeResource BodyTextBlockStyle}" | ||
| Text="{x:Bind ((storage:StorageFolder)Content).DisplayName}" /> | ||
| Text="{x:Bind ((storage:StorageFolder)Content).DisplayName}" | ||
| ToolTipService.ToolTip="{x:Bind ((storage:StorageFolder)Content).DisplayName}" /> | ||
| </StackPanel> | ||
| </DataTemplate> | ||
|
|
||
|
|
@@ -149,7 +154,8 @@ | |
| <TextBlock Margin="32,0" | ||
| VerticalAlignment="Center" | ||
| FontWeight="SemiBold" | ||
| Text="{Binding Title}" /> | ||
| Text="{Binding Title}" | ||
| ToolTipService.ToolTip="{Binding Title}"/> | ||
| <StackPanel Grid.Column="1" | ||
| ex:FrameworkElementExtensions.AncestorType="ListViewItem" | ||
| Orientation="Horizontal" | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the TextBlock ones, should we also add
TextTrimmingso that the filename is truncated more nicely?