Skip to content
Open
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions XamlStudio/Views/Explorer.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@
<TextBlock HorizontalAlignment="Left"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the TextBlock ones, should we also add TextTrimming so that the filename is truncated more nicely?

VerticalAlignment="Center"
Style="{ThemeResource BodyTextBlockStyle}"
Text="{x:Bind ((storage:StorageFile)Content).Name}" />
Text="{x:Bind ((storage:StorageFile)Content).Name}"
ToolTipService.ToolTip="{x:Bind ((storage:StorageFile)Content).Name}" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the Tooltip version, should we grab the fullpath along with this so that you can distinguish two files with the same name in different directories?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line specifically is in the work space tree view and should have no such confusion. Line 158 could use it though

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes, good point. I wasn't noticing where it was in the relation to the whole context. Thanks for redirecting my comment's intent to the right location. 🙂

I'll pull this down later and then get it merged in. I also forgot I hadn't setup a CI yet. I'll have to get on that later this week. 😅

</StackPanel>
</DataTemplate>

Expand All @@ -43,7 +44,8 @@
<TextBlock HorizontalAlignment="Left"
VerticalAlignment="Center"
Style="{ThemeResource BodyTextBlockStyle}"
Text="{x:Bind ((storage:StorageFile)Content).Name}" />
Text="{x:Bind ((storage:StorageFile)Content).Name}"
ToolTipService.ToolTip="{x:Bind ((storage:StorageFile)Content).Name}" />
</StackPanel>
</DataTemplate>

Expand All @@ -55,7 +57,8 @@
<TextBlock HorizontalAlignment="Left"
VerticalAlignment="Center"
Style="{ThemeResource BodyTextBlockStyle}"
Text="{x:Bind ((storage:StorageFile)Content).Name}" />
Text="{x:Bind ((storage:StorageFile)Content).Name}"
ToolTipService.ToolTip="{x:Bind ((storage:StorageFile)Content).Name}" />
<!-- Show Hover Preview of Image -->
<ToolTipService.ToolTip>
<Image Width="128"
Expand All @@ -74,7 +77,8 @@
<TextBlock HorizontalAlignment="Left"
VerticalAlignment="Center"
Style="{ThemeResource BodyTextBlockStyle}"
Text="{x:Bind ((storage:StorageFile)Content).Name}" />
Text="{x:Bind ((storage:StorageFile)Content).Name}"
ToolTipService.ToolTip="{x:Bind ((storage:StorageFile)Content).Name}" />
</StackPanel>
</DataTemplate>

Expand All @@ -84,7 +88,8 @@
<TextBlock HorizontalAlignment="Left"
VerticalAlignment="Center"
Style="{ThemeResource BodyTextBlockStyle}"
Text="{x:Bind ((storage:StorageFolder)Content).DisplayName}" />
Text="{x:Bind ((storage:StorageFolder)Content).DisplayName}"
ToolTipService.ToolTip="{x:Bind ((storage:StorageFolder)Content).DisplayName}" />
</StackPanel>
</DataTemplate>

Expand Down Expand Up @@ -149,7 +154,8 @@
<TextBlock Margin="32,0"
VerticalAlignment="Center"
FontWeight="SemiBold"
Text="{Binding Title}" />
Text="{Binding Title}"
ToolTipService.ToolTip="{Binding Title}"/>
<StackPanel Grid.Column="1"
ex:FrameworkElementExtensions.AncestorType="ListViewItem"
Orientation="Horizontal"
Expand Down
2 changes: 1 addition & 1 deletion XamlStudio/Views/MainPage.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@
</muxc:TabView.Resources>
<muxc:TabView.TabItemTemplate>
<DataTemplate x:DataType="models:XamlDocument">
<muxc:TabViewItem HorizontalContentAlignment="Stretch" ContextFlyout="{StaticResource TabItemFlyout}">
<muxc:TabViewItem ToolTipService.ToolTip="{x:Bind Title, Mode=OneWay}" HorizontalContentAlignment="Stretch" ContextFlyout="{StaticResource TabItemFlyout}">
<muxc:TabViewItem.Header>
<Grid>
<Grid.ColumnDefinitions>
Expand Down