Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Oct 9, 2024

Backport of #58307 to release/9.0

/cc @captainsafia

Validate scopes in OpenApiDocumentProvider tests and fix scope

Summary of the changes (Less than 80 chars)

Description

{Detail}

Fixes #{bug number} (in this specific format)

Customer Impact

{Justification}

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

When servicing release/2.1

  • Make necessary changes in eng/PatchConfig.props

@github-actions github-actions bot requested review from a team and captainsafia as code owners October 9, 2024 15:42
@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Oct 9, 2024
@captainsafia
Copy link
Member

Closing this backport for now. Our implementation will always favor the overload that takes in a version number:

var targetMethod = generateWithVersionMethod ?? generateMethod;

So users are unable to run into this in theory. If it does end up happening in practice, we can revisit a backport.

@dotnet-policy-service dotnet-policy-service bot added this to the 9.0.0 milestone Oct 11, 2024
@wtgodbe wtgodbe deleted the backport/pr-58307-to-release/9.0 branch November 15, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants