Skip to content

Fix flaky SignalR test: RequestTimeoutDisabledWhenConnected #59819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Fix flaky SignalR test: RequestTimeoutDisabledWhenConnected #59819

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dda264c
Fix flaky SignalR test: RequestTimeoutDisabledWhenConnected
BrennanConroy Jan 10, 2025
910affa
fix
BrennanConroy Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 33 additions & 1 deletion src/SignalR/common/Http.Connections/test/HttpConnectionDispatcherTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3525,7 +3525,7 @@ public async Task RequestTimeoutDisabledWhenConnected(HttpTransportType transpor
app.UseRouting();
app.UseEndpoints(endpoints =>
{
endpoints.MapConnectionHandler<TestConnectionHandler>("/foo");
endpoints.MapConnectionHandler<EchoConnectionHandler>("/foo");
});
})
.UseUrls("http://127.0.0.1:0");
Expand All @@ -3550,6 +3550,10 @@ public async Task RequestTimeoutDisabledWhenConnected(HttpTransportType transpor

await connection.StartAsync();

// Easy way to make sure everything is set is to send and receive data over the connection
await connection.Transport.Output.WriteAsync(new byte[2]);
Copy link
Member

@captainsafia captainsafia Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are two bytes necessary for this or is any number of bytes sufficient?

Copy link
Member Author

@BrennanConroy BrennanConroy Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any number, not sure why I put 2 😆

await connection.Transport.Input.ReadAsync();

var negotiateResponse = NegotiateProtocol.ParseResponse(stream.ToArray());

Assert.True(manager.TryGetConnection(negotiateResponse.ConnectionToken, out var context));
Expand Down Expand Up @@ -3898,6 +3902,34 @@ public override async Task OnConnectedAsync(ConnectionContext connection)
}
}

public class EchoConnectionHandler : ConnectionHandler
{
public override async Task OnConnectedAsync(ConnectionContext connection)
{
while (true)
{
var result = await connection.Transport.Input.ReadAsync();
var buffer = result.Buffer;

try
{
if (!buffer.IsEmpty)
{
await connection.Transport.Output.WriteAsync(buffer.ToArray());
}
else if (result.IsCompleted)
{
break;
}
}
finally
{
connection.Transport.Input.AdvanceTo(result.Buffer.End);
}
}
}
}

public class ServiceProviderConnectionHandler : ConnectionHandler
{
public override async Task OnConnectedAsync(ConnectionContext connection)
Expand Down
Loading