Skip to content

Fix handling for more method signature types #60464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 19, 2025
Merged

Fix handling for more method signature types #60464

merged 3 commits into from
Feb 19, 2025

Conversation

@captainsafia
Copy link
Member

@captainsafia captainsafia commented Feb 18, 2025 •
edited by danroth27
Loading

Fixes #60417.

Copilot AI review requested due to automatic review settings February 18, 2025 17:38
@captainsafia captainsafia requested a review from a team as a code owner February 18, 2025 17:38
@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Feb 18, 2025
Copilot AI reviewed Feb 18, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

martincostello
martincostello reviewed Feb 18, 2025
View reviewed changes
@captainsafia
Copy link
Member Author

captainsafia commented Feb 19, 2025

@BrennanConroy For your review: found some issues while bug bashing the XML doc support implementation.

martincostello
martincostello reviewed Feb 19, 2025
View reviewed changes
...i/test/Microsoft.AspNetCore.OpenApi.Build.Tests/GenerateAdditionalXmlFilesForOpenApiTests.cs
public class GenerateAdditionalXmlFilesForOpenApiTests
{
private static readonly TimeSpan _defaultProcessTimeout = TimeSpan.FromSeconds(45);
private static readonly TimeSpan _defaultProcessTimeout = TimeSpan.FromSeconds(120);
Copy link
Member

@martincostello martincostello Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nit:

Suggested change
private static readonly TimeSpan _defaultProcessTimeout = TimeSpan.FromSeconds(120);
private static readonly TimeSpan _defaultProcessTimeout = TimeSpan.FromMinutes(2);

@captainsafia captainsafia merged commit 73655ef into main Feb 19, 2025
27 checks passed
@captainsafia captainsafia deleted the safia/fix-xml-record-constructor branch February 19, 2025 23:26
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview2 milestone Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@BrennanConroy BrennanConroy BrennanConroy approved these changes

+1 more reviewer

@martincostello martincostello martincostello left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates

Projects

None yet

Milestone

10.0-preview2

Development

Successfully merging this pull request may close these issues.

XML document application should handle void-returning methods

4 participants

@captainsafia @martincostello @BrennanConroy