Fix flaky Http2 Trailers tests #60483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrennanConroy
requested review from
JamesNK,
halter73 and
mgravell
as code owners
ghost
added
the
area-networking
src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/Http2StreamTests.cs
Outdated
Show resolved
Hide resolved
…treamTests.cs Co-authored-by: Copilot <[email protected]>
JamesNK
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Http2FrameWriter has a background task that reads from a channel, if the background task isn't actively reading from the channel, then the
context.Response.CompleteAsync()call will not run the async continuation inline and race with the channel read loop and thecontext.Features.Get<IHttpResponseTrailersFeature>().Trailers.IsReadOnlycheck.