Skip to content

Fix flaky Http2 Trailers tests #60483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 19, 2025
Merged

Fix flaky Http2 Trailers tests #60483

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e35008
Fix flaky Http2 Trailers tests
BrennanConroy Feb 19, 2025
13808b3
Update src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/Http2S…
BrennanConroy Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 23 additions & 3 deletions src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/Http2StreamTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5239,10 +5239,10 @@ await InitializeConnectionAsync(async context =>

await context.Response.CompleteAsync().DefaultTimeout();

Assert.True(context.Features.Get<IHttpResponseTrailersFeature>().Trailers.IsReadOnly);

// Make sure the client gets our results from CompleteAsync instead of from the request delegate exiting.
await clientTcs.Task.DefaultTimeout();

Assert.True(context.Features.Get<IHttpResponseTrailersFeature>().Trailers.IsReadOnly);
appTcs.SetResult();
}
catch (Exception ex)
Expand Down Expand Up @@ -5432,6 +5432,7 @@ await WaitForStreamErrorAsync(1, Http2ErrorCode.INTERNAL_ERROR,
public async Task AbortAfterCompleteAsync_GETWithResponseBodyAndTrailers_ResetsAfterResponse()
{
var startingTcs = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);
var trailersTcs = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);
var appTcs = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);
var clientTcs = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);
var headers = new[]
Expand All @@ -5453,6 +5454,9 @@ await InitializeConnectionAsync(async context =>
context.Response.AppendTrailer("CustomName", "Custom Value");

await context.Response.CompleteAsync().DefaultTimeout();
// Http2FrameWriter sets Trailers.IsReadOnly to true, but since it's a background task we have to wait for something to indicate it ran
// That something is the client side receiving the trailers.
await trailersTcs.Task;

Assert.True(context.Features.Get<IHttpResponseTrailersFeature>().Trailers.IsReadOnly);

Expand Down Expand Up @@ -5484,6 +5488,7 @@ await InitializeConnectionAsync(async context =>
withLength: 25,
withFlags: (byte)(Http2HeadersFrameFlags.END_HEADERS | Http2HeadersFrameFlags.END_STREAM),
withStreamId: 1);
trailersTcs.SetResult();
// Stream should return an INTERNAL_ERROR. If there is an unexpected exception from app TCS instead, then throw it here to avoid timeout waiting for the stream error.
await Task.WhenAny(WaitForStreamErrorAsync(1, Http2ErrorCode.INTERNAL_ERROR, expectedErrorMessage: null), appTcs.Task).Unwrap();

Expand Down Expand Up @@ -5512,6 +5517,7 @@ await InitializeConnectionAsync(async context =>
public async Task AbortAfterCompleteAsync_POSTWithResponseBodyAndTrailers_RequestBodyThrows()
{
var startingTcs = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);
var trailersTcs = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);
var appTcs = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);
var clientTcs = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);
var headers = new[]
Expand All @@ -5535,7 +5541,10 @@ await InitializeConnectionAsync(async context =>
context.Response.AppendTrailer("CustomName", "Custom Value");

await context.Response.CompleteAsync().DefaultTimeout();

// Http2FrameWriter sets Trailers.IsReadOnly to true, but since it's a background task we have to wait for something to indicate it ran
// That something is the client side receiving the trailers.
await trailersTcs.Task;

Assert.True(context.Features.Get<IHttpResponseTrailersFeature>().Trailers.IsReadOnly);

// RequestAborted will no longer fire after CompleteAsync.
Expand Down Expand Up @@ -5569,6 +5578,7 @@ await InitializeConnectionAsync(async context =>
withLength: 25,
withFlags: (byte)(Http2HeadersFrameFlags.END_HEADERS | Http2HeadersFrameFlags.END_STREAM),
withStreamId: 1);
trailersTcs.SetResult();
await WaitForStreamErrorAsync(1, Http2ErrorCode.INTERNAL_ERROR, expectedErrorMessage: null);

clientTcs.SetResult();
Expand Down Expand Up @@ -5596,6 +5606,7 @@ await InitializeConnectionAsync(async context =>
public async Task ResetAfterCompleteAsync_GETWithResponseBodyAndTrailers_ResetsAfterResponse()
{
var startingTcs = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);
var trailersTcs = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);
var appTcs = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);
var clientTcs = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);
var headers = new[]
Expand All @@ -5617,6 +5628,9 @@ await InitializeConnectionAsync(async context =>
context.Response.AppendTrailer("CustomName", "Custom Value");

await context.Response.CompleteAsync().DefaultTimeout();
// Http2FrameWriter sets Trailers.IsReadOnly to true, but since it's a background task we have to wait for something to indicate it ran
// That something is the client side receiving the trailers.
await trailersTcs.Task;

Assert.True(context.Features.Get<IHttpResponseTrailersFeature>().Trailers.IsReadOnly);

Expand Down Expand Up @@ -5650,6 +5664,7 @@ await InitializeConnectionAsync(async context =>
withLength: 25,
withFlags: (byte)(Http2HeadersFrameFlags.END_HEADERS | Http2HeadersFrameFlags.END_STREAM),
withStreamId: 1);
trailerTcs.SetResult();
await WaitForStreamErrorAsync(1, Http2ErrorCode.NO_ERROR, expectedErrorMessage:
"The HTTP/2 stream was reset by the application with error code NO_ERROR.");

Expand Down Expand Up @@ -5678,6 +5693,7 @@ await WaitForStreamErrorAsync(1, Http2ErrorCode.NO_ERROR, expectedErrorMessage:
public async Task ResetAfterCompleteAsync_POSTWithResponseBodyAndTrailers_RequestBodyThrows()
{
var startingTcs = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);
var trailersTcs = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);
var appTcs = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);
var clientTcs = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);
var headers = new[]
Expand All @@ -5701,6 +5717,9 @@ await InitializeConnectionAsync(async context =>
context.Response.AppendTrailer("CustomName", "Custom Value");

await context.Response.CompleteAsync().DefaultTimeout();
// Http2FrameWriter sets Trailers.IsReadOnly to true, but since it's a background task we have to wait for something to indicate it ran
// That something is the client side receiving the trailers.
await trailersTcs.Task;

Assert.True(context.Features.Get<IHttpResponseTrailersFeature>().Trailers.IsReadOnly);

Expand Down Expand Up @@ -5737,6 +5756,7 @@ await InitializeConnectionAsync(async context =>
withLength: 25,
withFlags: (byte)(Http2HeadersFrameFlags.END_HEADERS | Http2HeadersFrameFlags.END_STREAM),
withStreamId: 1);
trailersTcs.SetResult();
await WaitForStreamErrorAsync(1, Http2ErrorCode.NO_ERROR, expectedErrorMessage:
"The HTTP/2 stream was reset by the application with error code NO_ERROR.");

Expand Down
Loading