Skip to content

Exclude .js files from signing #61643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2025
Merged

Exclude .js files from signing #61643

merged 1 commit into from
Apr 24, 2025

Conversation

@ellahathaway
Copy link
Member

Related to dotnet/sdk#48653

Default .js signing was removed from Arcade, so there's now an error when signing aspnetcore artifacts in the VMR:

D:\a_work\1\vmr\artifacts\source-built-sdks\Microsoft.DotNet.Arcade.Sdk\tools\Sign.proj(76,5): error : Skipping file 'D:\a_work\1\vmr\src\aspnetcore\artifacts\tmp\Release\ContainerSigning\940_framework/blazor.web.js' because .js files are no longer signed by default. To disable this warning, please explicitly define the FileExtensionSignInfo for the .js extension or set the MSBuild property 'NoSignJS' to 'true'.

This PR fixes that failure.

@ellahathaway ellahathaway requested review from a team and wtgodbe as code owners April 23, 2025 23:00
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Apr 23, 2025
@ellahathaway ellahathaway mentioned this pull request Apr 23, 2025
Closed
@ellahathaway ellahathaway enabled auto-merge (squash) April 23, 2025 23:08
@ellahathaway ellahathaway merged commit d7315db into dotnet:main Apr 24, 2025
26 of 27 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview5 milestone Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wtgodbe wtgodbe wtgodbe approved these changes

@ViktorHofer ViktorHofer Awaiting requested review from ViktorHofer

@mmitche mmitche Awaiting requested review from mmitche

Assignees

No one assigned

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Milestone

10.0-preview5

Development

Successfully merging this pull request may close these issues.

2 participants

@ellahathaway @wtgodbe