Skip to content

[main] Update dependencies from dotnet/arcade #48653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[main] Update dependencies from dotnet/arcade #48653

wants to merge 2 commits into from

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Apr 23, 2025 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20250…
3a7f70d 
…422.2

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions
 From Version 10.0.0-beta.25221.2 -> To Version 10.0.0-beta.25222.2
@ViktorHofer
Copy link
Member

ViktorHofer commented Apr 23, 2025 •
edited
Loading

D:\a_work\1\vmr\artifacts\source-built-sdks\Microsoft.DotNet.Arcade.Sdk\tools\Sign.proj(76,5): error : Skipping file 'D:\a_work\1\vmr\src\aspnetcore\artifacts\tmp\Release\ContainerSigning\940_framework/blazor.web.js' because .js files are no longer signed by default. To disable this warning, please explicitly define the FileExtensionSignInfo for the .js extension or set the MSBuild property 'NoSignJS' to 'true'.

@ellahathaway @mmitche

I assume that we need to react to this in aspnetcore?

@mmitche
Copy link
Member

mmitche commented Apr 23, 2025

D:\a_work\1\vmr\artifacts\source-built-sdks\Microsoft.DotNet.Arcade.Sdk\tools\Sign.proj(76,5): error : Skipping file 'D:\a_work\1\vmr\src\aspnetcore\artifacts\tmp\Release\ContainerSigning\940_framework/blazor.web.js' because .js files are no longer signed by default. To disable this warning, please explicitly define the FileExtensionSignInfo for the .js extension or set the MSBuild property 'NoSignJS' to 'true'.

@ellahathaway @mmitche

I assume that we need to react to this in aspnetcore?

Yes correct.

@ViktorHofer
Copy link
Member

Can you or @ellahathaway please help with that (I'm logging off now)? Not sure if the blocking dependency flow will cause issues in tomorrow's migration.

@ellahathaway
Copy link
Member

ellahathaway commented Apr 23, 2025 •
edited
Loading

Can you or @ellahathaway please help with that (I'm logging off now)? Not sure if the blocking dependency flow will cause issues in tomorrow's migration.

Yep will take a look.

Edit: dotnet/aspnetcore#61643 should fix the issue

@ellahathaway ellahathaway mentioned this pull request Apr 23, 2025
Merged
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20250…
41d7954 
…423.2

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions
 From Version 10.0.0-beta.25221.2 -> To Version 10.0.0-beta.25223.2
@build-analysis build-analysis bot mentioned this pull request Apr 24, 2025
Open
3 tasks
@akoeplinger
Copy link
Member

Closing in favor of VMR subscription.

@dotnet-maestro dotnet-maestro bot deleted the darc-main-ded659f1-6dc0-4357-96c0-d5f12dd7c5ee branch April 24, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@premun premun premun approved these changes

Assignees

No one assigned

Labels

Area-CodeFlow

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ViktorHofer @mmitche @ellahathaway @akoeplinger @premun