-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Update browser testing dependencies: Selenium 4.35.0 #63094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: DeagleGross <[email protected]>
/azp run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates browser testing dependencies to their latest versions, specifically Selenium from 4.34.0 to 4.35.0 and Playwright from 1.54.0 to 1.55.0. The changes ensure version consistency between package references and Docker images used in testing infrastructure.
- Updated Selenium WebDriver and Support packages to version 4.35.0
- Updated Microsoft Playwright package to version 1.55.0
- Synchronized Playwright Docker image version with package version in benchmark applications
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
eng/Versions.props | Updated version properties for Selenium and Playwright packages |
src/Components/benchmarkapps/Wasm.Performance/dockerfile | Updated Playwright Docker image tag to match package version |
Azure Pipelines successfully started running 4 pipeline(s). |
Ah, since these are external packages, we also need to mirror the packages to |
thanks Will! launched pipeline: https://dev.azure.com/dnceng/internal/_build/results?buildId=2767084&view=results |
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
@copilot please revert upgrading playwright version - there is no 1.55 you need to check it more carefully next time! |
Co-authored-by: DeagleGross <[email protected]>
... You're absolutely right - I apologize for the error. I've reverted the Playwright version back to 1.54.0 in both the package version and Docker image. The Selenium updates to 4.35.0 remain as they are valid. Fixed in commit f56023c. |
ok it appears all of packages Copilot tried to update are on the latest version already :) I need to update the instructions to not do it blindly, but do nothing if there is nothing to update |
This PR updates the Selenium browser testing dependencies used throughout the AspNetCore repository for automated E2E integration testing.
Changes Made
Selenium Package Updates
Updated Selenium packages in
eng/Versions.props
:SeleniumWebDriverVersion
: 4.34.0 → 4.35.0SeleniumSupportVersion
: 4.34.0 → 4.35.0Key Points
The changes affect E2E testing infrastructure that uses Selenium for browser automation.
@dotnet/aspnet-build Please review these dependency updates for browser testing tools.
Fixes #63028.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.