Skip to content

Fixes issue in generating TypeSpec for responses without a body. Closes #1260 #1264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waldekmastykarz merged 1 commit into from
Jun 24, 2025
Merged

Fixes issue in generating TypeSpec for responses without a body. Closes #1260 #1264

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 21 additions & 14 deletions DevProxy.Plugins/Generation/TypeSpecGeneratorPlugin.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,25 +399,32 @@ private async Task ProcessResponseAsync(Response? httpResponse, TypeSpecFile doc
.ToDictionary(h => h.Name.ToCamelCase(), h => h.Value.GetType().Name)
};

var models = await GetModelsFromStringAsync(httpResponse.BodyString, lastSegment.ToPascalCase(), httpResponse.StatusCode >= 400);
if (models.Length > 0)
if (httpResponse.HasBody)
{
foreach (var model in models)
var models = await GetModelsFromStringAsync(httpResponse.BodyString, lastSegment.ToPascalCase(), httpResponse.StatusCode >= 400);
if (models.Length > 0)
{
_ = doc.Service.Namespace.MergeModel(model);
}
foreach (var model in models)
{
_ = doc.Service.Namespace.MergeModel(model);
}

var rootModel = models.Last();
if (rootModel.IsArray)
{
res.BodyType = $"{rootModel.Name}[]";
op.Name = await GetOperationNameAsync("list", url);
}
else
{
res.BodyType = rootModel.Name;
var rootModel = models.Last();
if (rootModel.IsArray)
{
res.BodyType = $"{rootModel.Name}[]";
op.Name = await GetOperationNameAsync("list", url);
}
else
{
res.BodyType = rootModel.Name;
}
}
}
else
{
Logger.LogDebug("Response has no body");
}
}

op.MergeResponse(res);
Expand Down