fix: Underscore astoria snippet paths #11784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nschonni
changed the title
nschonni
added a commit
to nschonni/dotnet-samples
that referenced
this pull request
Apr 11, 2019
Related to dotnet/docs#11784 Some files were deleted because they are gitignored
Merged
rpetrusha
pushed a commit
to dotnet/samples
that referenced
this pull request
Apr 11, 2019
Related to dotnet/docs#11784 Some files were deleted because they are gitignored
|
Closing and reopening to begin new build. |
|
@nschonni, the build report shows 19 warnings because of unresolved code references. |
|
Looks like I missed some under "xml", I only renamed them under visualbasic and csharp. Not sure about the few csharp ones that are still erroring |
|
Starting a new build... |
|
6 more warnings... |
|
@mairaw thanks for fixing those up, I was just checking again to see if it was the samples again, but it looks like I messed up a a find/replace somewhere |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll be submitted dotnet/samples#810 in the samples repo to match