Improve clarity of protected access modifier documentation with unified examples and comparison table #47117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed examples and comparison table Co-authored-by: BillWagner <[email protected]>
Copilot
AI
changed the title
[WIP] It's not clear difference between protected, private protected, and protected internal from given example.
Improve clarity of protected access modifier documentation with unified examples and comparison table
Jul 7, 2025
Copilot finished work on behalf of
BillWagner
July 7, 2025 18:13
dotnet-policy-service
bot
added
the
okr-quality
BillWagner
reviewed
Jul 8, 2025
Member
BillWagner
left a comment
BillWagner
left a comment
There was a problem hiding this comment.
This is a good start, but I have a few comments.
…mentation Co-authored-by: BillWagner <[email protected]>
Copilot finished work on behalf of
BillWagner
July 8, 2025 14:21
BillWagner
reviewed
Jul 8, 2025
Member
BillWagner
left a comment
BillWagner
left a comment
There was a problem hiding this comment.
Good work. One more set of changes.
Member
|
@copilot Can you start working on this again? |
Copilot stopped work on behalf of
BillWagner due to an error
July 9, 2025 13:14
Member
|
@copilot Can you start working on this again? |
Copilot stopped work on behalf of
BillWagner due to an error
July 10, 2025 12:24
Member
|
@copilot Can you start working on this again? |
…d.md Co-authored-by: BillWagner <[email protected]>
Copilot finished work on behalf of
BillWagner
July 10, 2025 20:27
BillWagner
reviewed
Jul 14, 2025
docs/csharp/language-reference/keywords/snippets/protected/protected.csproj
Outdated
Show resolved
Hide resolved
…project file Co-authored-by: BillWagner <[email protected]>
Member
|
The snippets failure is related to a preview feature. |
IEvangelist
reviewed
Jul 15, 2025
IEvangelist
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation for
protected,private protected, andprotected internalaccess modifiers was difficult to compare because examples used different member names, inconsistent structures, and lacked clear explanations of the key differences between these related modifiers.Changes Made
Unified Examples and Naming
myValueas the member name for consistencyAssembly1.cs,Assembly2.cs) across all examplesprotected.mdto use inline examples instead of external code referencesEnhanced Explanations
New Comparison Table
Added a clear comparison table in
private-protected.md:protectedprotected internalprivate protectedUsage Guidelines
Added clear guidance on when to use each modifier:
protectedwhen you want derived classes in any assembly to access the memberprotected internalwhen you want the most permissive accessprivate protectedwhen you want the most restrictive protected accessThese changes make it much easier for developers to understand the differences between these three related access modifiers and choose the appropriate one for their needs.
Fixes #23465.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
Internal previews