-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Improve clarity of protected access modifier documentation with unified examples and comparison table #47117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ad66523
Initial plan
Copilot 857e717
Improve clarity of protected access modifier documentation with unifi…
Copilot 04a6993
Move inline code examples to snippet files for protected keyword docu…
Copilot 8ea05ca
Replace !code-csharp with ::: directive for code snippets in protecte…
Copilot 0fed6a6
Replace old code reference with ::: directive and remove unnecessary …
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
docs/csharp/language-reference/keywords/snippets/protected/Assembly1.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| //<snippet1> | ||
| // Assembly1.cs | ||
| // Compile with: /target:library | ||
| namespace Assembly1 | ||
| { | ||
| public class BaseClass | ||
| { | ||
| protected int myValue = 0; | ||
| } | ||
| } | ||
| //</snippet1> |
18 changes: 18 additions & 0 deletions
18
docs/csharp/language-reference/keywords/snippets/protected/Assembly2.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| //<snippet1> | ||
| // Assembly2.cs | ||
| // Compile with: /reference:Assembly1.dll | ||
| namespace Assembly2 | ||
| { | ||
| using Assembly1; | ||
|
|
||
| class DerivedClass : BaseClass | ||
| { | ||
| void Access() | ||
| { | ||
| // OK, because protected members are accessible from | ||
| // derived classes in any assembly | ||
| myValue = 10; | ||
| } | ||
| } | ||
| } | ||
| //</snippet1> |
25 changes: 25 additions & 0 deletions
25
docs/csharp/language-reference/keywords/snippets/protected/Example1.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| //<snippet1> | ||
| namespace Example1 | ||
| { | ||
| class BaseClass | ||
| { | ||
| protected int myValue = 123; | ||
| } | ||
|
|
||
| class DerivedClass : BaseClass | ||
| { | ||
| static void Main() | ||
| { | ||
| var baseObject = new BaseClass(); | ||
| var derivedObject = new DerivedClass(); | ||
|
|
||
| // Error CS1540, because myValue can only be accessed through | ||
| // the derived class type, not through the base class type. | ||
| // baseObject.myValue = 10; | ||
|
|
||
| // OK, because this class derives from BaseClass. | ||
| derivedObject.myValue = 10; | ||
| } | ||
| } | ||
| } | ||
| //</snippet1> |
24 changes: 24 additions & 0 deletions
24
docs/csharp/language-reference/keywords/snippets/protected/Example2.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| //<snippet1> | ||
| namespace Example2 | ||
| { | ||
| class Point | ||
| { | ||
| protected int x; | ||
| protected int y; | ||
| } | ||
|
|
||
| class DerivedPoint: Point | ||
| { | ||
| static void Main() | ||
| { | ||
| var dpoint = new DerivedPoint(); | ||
|
|
||
| // Direct access to protected members. | ||
| dpoint.x = 10; | ||
| dpoint.y = 15; | ||
| Console.WriteLine($"x = {dpoint.x}, y = {dpoint.y}"); | ||
| } | ||
| } | ||
| // Output: x = 10, y = 15 | ||
| } | ||
| //</snippet1> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.