Skip to content

Conversation

FilipToth
Copy link
Contributor

Summary

Added documentation coverage for IsRealNumber methods' handling of infinities, which may seem unintuitive to some developers. For further details, refer to the linked issue.

A separate PR will be submitted into dotnet/runtime to update inline documentation comments once this change is approved, in order to avoid simultaneous changes across two repos.

Fixes dotnet/runtime#103930

This comment was marked as outdated.

Copy link

Learn Build status updates of commit e07db1b:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Numerics/Complex.xml ✅Succeeded View
xml/System.Numerics/INumberBase`1.xml ✅Succeeded View
xml/System.Runtime.InteropServices/NFloat.xml ✅Succeeded View
xml/System/Double.xml ✅Succeeded View
xml/System/Half.xml ✅Succeeded View
xml/System/Single.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@AaronRobinsonMSFT
Copy link
Member

@tannergooding Are you okay with this update?

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Oct 15, 2024
Copy link

Learn Build status updates of commit de098e3:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Numerics/INumberBase`1.xml ✅Succeeded View
xml/System.Runtime.InteropServices/NFloat.xml ✅Succeeded View
xml/System/Double.xml ✅Succeeded View
xml/System/Half.xml ✅Succeeded View
xml/System/Single.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@gewarren gewarren enabled auto-merge (squash) October 16, 2024 17:20
@gewarren gewarren merged commit fc5f40f into dotnet:main Oct 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Numerics community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System.Double.IsRealNumber(System.Double.PositiveInfinity) is true
4 participants