coreclr: Automatic port of triple slash from System.Text.Unicode #2722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossanlop
requested review from
mairaw,
rpetrusha,
GrabYourPitchforks,
layomia and
tarekgh
carlossanlop
added
🏁 Release: .NET Core 3.0
Documented "to be added" items, fixed links, added remarks
rpetrusha
approved these changes
Jul 9, 2019
There was a problem hiding this comment.
I've fixed broken links, documented the remaining "to be added" items, and expanded the remarks for the two members. Let me know if anything needs to be changed, @carlossanlop @GrabYourPitchforks @tarekgh and @layomia.
carlossanlop
commented
Jul 11, 2019
mairaw
removed
the
waiting-on-reviews
ahsonkhan
reviewed
Sep 18, 2019
| <param name="charsRead">When the method returns, the number of characters read from <paramref name="source" />.</param> | ||
| <param name="bytesWritten">When the method returns, the number of characters written to <paramref name="destination" />.</param> | ||
| <param name="replaceInvalidSequences"><see langword="true" /> to replace invalid UTF-16 sequences in <paramref name="source" /> with U+FFFD; <see langword="false" /> to return <see cref="F:System.Buffers.OperationStatus.InvalidData" /> if invalid characters are found in <paramref name="source" />.</param> | ||
| <param name="isFinalBlock"><see langword="true" /> if the method should not return <see cref="F:System.Buffers.OperationStatus.InvalidData" />; otherwise, <see langword="false" />.</param> |
There was a problem hiding this comment.
@rpetrusha - this documentation is inaccurate. I have submitted a fix for it.
See #3208
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Area owners @GrabYourPitchforks, @layomia, @tarekgh please make sure the descriptions are correct. After I check-in this PR, please feel free to start manually documenting the rest of the APIs that didn't have any triple slash comments that could be automatically ported.
Adding @mairaw @rpetrusha for language review.