Update S.T.Unicode.Utf8 APIs to correctly document the isFinalBlock bool. #3208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossanlop
added
🏁 Release: .NET Core 3.0
carlossanlop
approved these changes
Sep 18, 2019
There was a problem hiding this comment.
LGTM. The build passed without warnings. Let's wait for @mairaw/@rpetrusha to double check everything so they can merge this.
rpetrusha
approved these changes
Oct 2, 2019
There was a problem hiding this comment.
This looks good, @ahsonkhan and @carlossanlop. I'll merge it now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the change made from #2722 given the implementation and source comments:
https://github.com/dotnet/coreclr/blob/d4ab484be11b54eb92204cd084638a03a8f9c441/src/System.Private.CoreLib/shared/System/Text/Unicode/Utf8.cs#L30-L31
cc @GrabYourPitchforks, @carlossanlop, @rpetrusha, @mairaw