Skip to content

Add missing CmsRecipient docs, make existing docs match style guide #2800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2019
Merged

Add missing CmsRecipient docs, make existing docs match style guide #2800

merged 1 commit into from
Jul 23, 2019

Conversation

bartonjs
Copy link
Member

A lot of the current text didn't match the style guidelines, so I made it conform rather than having the new content have shear or a matching bad-style.

cc: @carlossanlop @mairaw @rpetrusha

@carlossanlop carlossanlop requested review from mairaw and rpetrusha July 23, 2019 05:02
@carlossanlop carlossanlop added 🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0 new-content Indicates PRs that contain new articles waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews labels Jul 23, 2019
@mairaw mairaw added this to the July 2019 milestone Jul 23, 2019
rpetrusha
rpetrusha approved these changes Jul 23, 2019
View reviewed changes
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @bartonjs, both for documenting new members as well as standardizing the documentation of existing members. I'll merge your PR now.

@rpetrusha rpetrusha merged commit 8d239e9 into dotnet:master Jul 23, 2019
@bartonjs bartonjs deleted the cmsrecipient branch July 23, 2019 20:52
@mairaw mairaw removed the waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews label Jul 23, 2019
@bartonjs bartonjs mentioned this pull request Jul 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mairaw mairaw Awaiting requested review from mairaw

1 more reviewer

@rpetrusha rpetrusha rpetrusha approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@bartonjs bartonjs

Labels
🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0 new-content Indicates PRs that contain new articles
Projects
None yet
Milestone
July 2019
Development

Successfully merging this pull request may close these issues.
4 participants
@bartonjs @rpetrusha @carlossanlop @mairaw