Skip to content

Add missing CmsSigner docs, make existing docs match style guide #2807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 24, 2019

Conversation

bartonjs
Copy link
Member

Similar to CmsRecipient (#2800), the type was small enough that I went ahead and aligned the existing members (and corrected out of date information) to the current style while adding documentation to the new members.

In this type pretty much every member had a seealso for every other member, I've pared it down to things that are more relevant to each thing.

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great set of changes @bartonjs! Left a few comments for you to consider.

@mairaw mairaw added doc-enhancement Improve the current content new-content Indicates PRs that contain new articles labels Jul 24, 2019
@mairaw mairaw added this to the July 2019 milestone Jul 24, 2019
@mairaw mairaw added the 🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0 label Jul 24, 2019
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks so much better with your changes. Thanks!

@mairaw mairaw merged commit d4dd4f7 into dotnet:master Jul 24, 2019
@bartonjs bartonjs deleted the cmssigner branch July 25, 2019 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0 doc-enhancement Improve the current content new-content Indicates PRs that contain new articles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants