Automatically port Reflection.AssemblyFlags #3184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossanlop
added
new-content
carlossanlop
requested review from
GrabYourPitchforks,
steveharter,
rpetrusha and
mairaw
rpetrusha
suggested changes
Sep 18, 2019
| @@ -49,7 +49,7 @@ | |||
| </ReturnValue> | |||
There was a problem hiding this comment.
Is a description available for the AssemblyFlags type itself?
There was a problem hiding this comment.
There isn't one. Otherwise, the tool would've caught it and ported it: src/System.Reflection.Metadata/src/System/Reflection/System.Reflection.cs#L193
There was a problem hiding this comment.
@steveharter @GrabYourPitchforks would you mind providing a description for this enum?
Co-Authored-By: Ron Petrusha <[email protected]>
rpetrusha
approved these changes
Oct 2, 2019
|
This looks good, @carlossanlop. The outstanding issue is a type description, but we can add that later. I'll merge the PR now. |
|
Thank you @rpetrusha, yes. We can add it later. |
mairaw
removed
the
waiting-on-reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Area owners: @steveharter @GrabYourPitchforks