Skip to content

Automatically port Reflection.AssemblyFlags #3184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2019
Merged

Automatically port Reflection.AssemblyFlags #3184

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56c5a10
Automatically port Reflection.AssemblyFlags
carlossanlop Sep 16, 2019
eacbf91
suggestions by rpetrusha
carlossanlop Sep 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions xml/System.Reflection/AssemblyFlags.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
</ReturnValue>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is a description available for the AssemblyFlags type itself?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There isn't one. Otherwise, the tool would've caught it and ported it: src/System.Reflection.Metadata/src/System/Reflection/System.Reflection.cs#L193

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@steveharter @GrabYourPitchforks would you mind providing a description for this enum?

<MemberValue>3584</MemberValue>
<Docs>
<summary>To be added.</summary>
<summary>Content type masked bits that correspond to values of <see cref="T:System.Reflection.AssemblyContentType" />.</summary>
</Docs>
</Member>
<Member MemberName="DisableJitCompileOptimizer">
Expand All @@ -74,7 +74,7 @@
</ReturnValue>
<MemberValue>16384</MemberValue>
<Docs>
<summary>To be added.</summary>
<summary>Specifies that Just-In-Time (JIT) compiler optimization is disabled for the assembly.</summary>
</Docs>
</Member>
<Member MemberName="EnableJitCompileTracking">
Expand All @@ -99,7 +99,7 @@
</ReturnValue>
<MemberValue>32768</MemberValue>
<Docs>
<summary>To be added.</summary>
<summary>Specifies that Just-In-Time (JIT) compiler tracking is enabled for the assembly.</summary>
</Docs>
</Member>
<Member MemberName="PublicKey">
Expand All @@ -124,7 +124,7 @@
</ReturnValue>
<MemberValue>1</MemberValue>
<Docs>
<summary>To be added.</summary>
<summary>The assembly reference holds the full (unhashed) public key. Not applicable on assembly definition.</summary>
</Docs>
</Member>
<Member MemberName="Retargetable">
Expand All @@ -149,7 +149,7 @@
</ReturnValue>
<MemberValue>256</MemberValue>
<Docs>
<summary>To be added.</summary>
<summary>The implementation of the referenced assembly used at runtime is not expected to match the version seen at compile time.</summary>
</Docs>
</Member>
<Member MemberName="WindowsRuntime">
Expand All @@ -174,7 +174,7 @@
</ReturnValue>
<MemberValue>512</MemberValue>
<Docs>
<summary>To be added.</summary>
<summary>The assembly contains Windows Runtime code.</summary>
</Docs>
</Member>
</Members>
Expand Down