Automatically port Reflection ManifestResourceAttributes and MethodSemanticsAttributes #3189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…manticsAttributes
carlossanlop
added
new-content
carlossanlop
requested review from
GrabYourPitchforks,
steveharter,
rpetrusha and
mairaw
steveharter
reviewed
Sep 17, 2019
steveharter
approved these changes
Sep 17, 2019
rpetrusha
approved these changes
Sep 25, 2019
There was a problem hiding this comment.
I've made some minor changes in case for ManifestResourceAttributes, @carlossanlop. For MethodSemanticsAttributes, remarks for individual enumeration members are not currently supported by our build system, so I've moved them into the summaries. I'm marking this as approved and verify build before merge, but please review the changes to make sure they're OK.
rpetrusha
added
verify-build-before-merge
and removed
waiting-on-reviews
carlossanlop
commented
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Area owners: @steveharter @GrabYourPitchforks