Skip to content

Automatically port Reflection ManifestResourceAttributes and MethodSemanticsAttributes #3189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 30, 2019
Merged

Automatically port Reflection ManifestResourceAttributes and MethodSemanticsAttributes #3189

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e895f66
Automatically port Reflection ManifestResourceAttributes and MethodSe…
carlossanlop Sep 16, 2019
9abab0c
suggestion by steveharter
carlossanlop Sep 18, 2019
767d84f
Moved remarks to summary.
Sep 25, 2019
5584c00
Corrected case.
Sep 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions xml/System.Reflection/ManifestResourceAttributes.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
</ReturnValue>
<MemberValue>2</MemberValue>
<Docs>
<summary>To be added.</summary>
<summary>The Resource is not exported from the Assembly.</summary>
</Docs>
</Member>
<Member MemberName="Public">
Expand All @@ -74,7 +74,7 @@
</ReturnValue>
<MemberValue>1</MemberValue>
<Docs>
<summary>To be added.</summary>
<summary>The Resource is exported from the Assembly.</summary>
</Docs>
</Member>
<Member MemberName="VisibilityMask">
Expand All @@ -99,7 +99,7 @@
</ReturnValue>
<MemberValue>7</MemberValue>
<Docs>
<summary>To be added.</summary>
<summary>Masks just the visibility-related attributes.</summary>
</Docs>
</Member>
</Members>
Expand Down
59 changes: 53 additions & 6 deletions xml/System.Reflection/MethodSemanticsAttributes.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,18 @@
</ReturnValue>
<MemberValue>8</MemberValue>
<Docs>
<summary>To be added.</summary>
<summary>Used to add a handler for an event.</summary>
<remarks>
<format type="text/markdown"><![CDATA[

## Remarks

Corresponds to the `AddOn` flag in the Ecma 335 CLI specification.

CLS-compliant adders are named with `add_` prefix.

]]></format>
</remarks>
</Docs>
</Member>
<Member MemberName="Getter">
Expand All @@ -71,7 +82,16 @@
</ReturnValue>
<MemberValue>2</MemberValue>
<Docs>
<summary>To be added.</summary>
<summary>Used to read the value of the property.</summary>
<remarks>
<format type="text/markdown"><![CDATA[

## Remarks

CLS-compliant getters are named with `get_` prefix.

]]></format>
</remarks>
</Docs>
</Member>
<Member MemberName="Other">
Expand All @@ -95,7 +115,7 @@
</ReturnValue>
<MemberValue>4</MemberValue>
<Docs>
<summary>To be added.</summary>
<summary>Other method for property (not getter or setter) or event (not adder, remover, or raiser).</summary>
</Docs>
</Member>
<Member MemberName="Raiser">
Expand All @@ -119,7 +139,16 @@
</ReturnValue>
<MemberValue>32</MemberValue>
<Docs>
<summary>To be added.</summary>
<summary>Used to indicate that an event has occurred.</summary>
<remarks>
<format type="text/markdown"><![CDATA[

## Remarks

Corresponds to the `Fire` flag in the Ecma 335 CLI specification. CLS-compliant raisers are named with `raise_` prefix.

]]></format>
</remarks>
</Docs>
</Member>
<Member MemberName="Remover">
Expand All @@ -143,7 +172,16 @@
</ReturnValue>
<MemberValue>16</MemberValue>
<Docs>
<summary>To be added.</summary>
<summary>Used to remove a handler for an event.</summary>
<remarks>
<format type="text/markdown"><![CDATA[

## Remarks

Corresponds to the `RemoveOn` flag in the Ecma 335 CLI specification. CLS-compliant removers are named with `remove_` prefix.

]]></format>
</remarks>
</Docs>
</Member>
<Member MemberName="Setter">
Expand All @@ -167,7 +205,16 @@
</ReturnValue>
<MemberValue>1</MemberValue>
<Docs>
<summary>To be added.</summary>
<summary>Used to modify the value of the property.</summary>
<remarks>
<format type="text/markdown"><![CDATA[

## Remarks

CLS-compliant setters are named with `set_` prefix.

]]></format>
</remarks>
</Docs>
</Member>
</Members>
Expand Down