Skip to content

updating Hashset`1.xml for Try .NET #3222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

WilliamAntonRohm
Copy link
Contributor

samples PR is dotnet/samples#1533

@WilliamAntonRohm
Copy link
Contributor Author

@mairaw, @BillWagner -- please review these updates at your convenience.

@Thraka Thraka added the vendor-project Indicates the issue/pr is related to a vendor project. label Oct 2, 2019
@Thraka
Copy link
Contributor

Thraka commented Oct 2, 2019

Just FYI I tried the first snippet on the hashset article and it wouldn't compile and run in the try browser

@WilliamAntonRohm
Copy link
Contributor Author

@Thraka -- Andy, that is strange. The updated sample files have been merged, so this snippet should be working.

@mairaw, @BillWagner -- in that generated article's HTML page source, I see my own fork referenced (?!) for the data-src -- how can I fix that?

<pre><code class="lang-csharp" data-interactive="csharp" data-src="https://github.com/WilliamAntonRohm/dotnet-api-docs/blob/hashset/snippets/csharp/VS_Snippets_CLR_System/system.Collections.Generic.HashSet_UnionWith/cs/Program.cs" name="System.Collections.Generic.HashSet_UnionWith#01">using System;

@mairaw
Copy link
Contributor

mairaw commented Oct 23, 2019

After the samples are merged, two things need to happen:

  • An internal build of the target branch needs to be done (but since it has been so long the master branch has been built many times)
  • This PR needs to be rebuilt

@WilliamAntonRohm
Copy link
Contributor Author

Replaced by new PR #3430.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vendor-project Indicates the issue/pr is related to a vendor project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants