Skip to content

Try .Net updates -- HashSet`1.xml refresh for out-of-sync PR 3222 #3430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 17, 2020

Conversation

WilliamAntonRohm
Copy link
Contributor

old PR -- #3222

already merged samples -- dotnet/samples#1533

@WilliamAntonRohm
Copy link
Contributor Author

@mairaw -- please review these changes.

@mairaw mairaw added the vendor-project Indicates the issue/pr is related to a vendor project. label Nov 11, 2019
@mairaw mairaw added this to the November 2019 milestone Nov 19, 2019
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes @WilliamAntonRohm. I've left a few comments to be addressed before merging.

@WilliamAntonRohm
Copy link
Contributor Author

@mairaw -- Maira, I've updated the article per your comments -- please review. As I recall, you mentioned a way to Resolve all conversations at once?

@mairaw
Copy link
Contributor

mairaw commented Dec 18, 2019

Some can be automatically resolved when you apply my suggestions via the GitHub UI. Otherwise, you need to resolve them individually.

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @WilliamAntonRohm. Still not quite ready.

Also trying to make some snippet tags better synced between C# and VB:
dotnet/samples#1861

@WilliamAntonRohm
Copy link
Contributor Author

@mairaw -- Maira, please review these changes.

@mairaw mairaw modified the milestones: November 2019, January 2020 Jan 7, 2020
@mairaw
Copy link
Contributor

mairaw commented Jan 7, 2020

Needs a new build

@mairaw mairaw closed this Jan 7, 2020
@mairaw mairaw reopened this Jan 7, 2020
@mairaw
Copy link
Contributor

mairaw commented Jan 17, 2020

There's only one API not working right now: https://review.docs.microsoft.com/en-us/dotnet/api/system.collections.generic.hashset-1.clear?view=netframework-4.8&branch=pr-en-us-3430#code-try-1

I believe with the fix I just made, we should be able to merge this.

@mairaw mairaw merged commit 7f46731 into dotnet:master Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vendor-project Indicates the issue/pr is related to a vendor project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants