-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Try .Net updates -- HashSet`1.xml refresh for out-of-sync PR 3222 #3430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@mairaw -- please review these changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great changes @WilliamAntonRohm. I've left a few comments to be addressed before merging.
@mairaw -- Maira, I've updated the article per your comments -- please review. As I recall, you mentioned a way to Resolve all conversations at once? |
Some can be automatically resolved when you apply my suggestions via the GitHub UI. Otherwise, you need to resolve them individually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @WilliamAntonRohm. Still not quite ready.
Also trying to make some snippet tags better synced between C# and VB:
dotnet/samples#1861
Co-Authored-By: Maira Wenzel <[email protected]>
Co-Authored-By: Maira Wenzel <[email protected]>
Co-Authored-By: Maira Wenzel <[email protected]>
@mairaw -- Maira, please review these changes. |
Needs a new build |
There's only one API not working right now: https://review.docs.microsoft.com/en-us/dotnet/api/system.collections.generic.hashset-1.clear?view=netframework-4.8&branch=pr-en-us-3430#code-try-1 I believe with the fix I just made, we should be able to merge this. |
old PR -- #3222
already merged samples -- dotnet/samples#1533