Skip to content

Object.xml -- updating for Try .NET #3346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 20, 2019
Merged

Conversation

WilliamAntonRohm
Copy link
Contributor

associated samples PR is dotnet/samples#1640

@mairaw mairaw closed this Oct 15, 2019
@mairaw mairaw reopened this Oct 15, 2019
@mairaw mairaw added the vendor-project Indicates the issue/pr is related to a vendor project. label Oct 22, 2019
@mairaw mairaw added this to the October 2019 milestone Oct 22, 2019
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @WilliamAntonRohm. Most of my feedback is regarding the presence of the interactive note on specific pages and one change that needs to be undone.

@WilliamAntonRohm
Copy link
Contributor Author

@mairaw -- Maira, I believe I've addressed all your review comments. Thank you for your continued assistance.

@WilliamAntonRohm
Copy link
Contributor Author

#sign-off

@mairaw
Copy link
Contributor

mairaw commented Dec 6, 2019

Resolved some merge conflicts

@mairaw mairaw modified the milestones: October 2019, December 2019 Dec 20, 2019
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to verify the build looks good and as expected but I think this one is ready to merge after the changes I made.

@mairaw
Copy link
Contributor

mairaw commented Dec 20, 2019

OPS build finished successfully so merging this.

@mairaw mairaw merged commit 13c5547 into dotnet:master Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vendor-project Indicates the issue/pr is related to a vendor project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants