Skip to content

Object.xml -- updating samples for Try .NET #1640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 15, 2019
Merged

Object.xml -- updating samples for Try .NET #1640

merged 2 commits into from
Oct 15, 2019

Conversation

WilliamAntonRohm
Copy link
Contributor

@WilliamAntonRohm WilliamAntonRohm commented Oct 14, 2019 •
edited
Loading

@WilliamAntonRohm WilliamAntonRohm mentioned this pull request Oct 14, 2019
Merged
mairaw
mairaw requested changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @WilliamAntonRohm. Changes look great. Just that one sample needs to be reverted.

@mairaw mairaw added this to the October 2019 milestone Oct 15, 2019
mairaw
mairaw approved these changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mairaw mairaw merged commit be11327 into dotnet:master Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mairaw mairaw mairaw approved these changes

@BillWagner BillWagner Awaiting requested review from BillWagner

Assignees

@WilliamAntonRohm WilliamAntonRohm

Labels
None yet
Projects
None yet
Milestone
October 2019
Development

Successfully merging this pull request may close these issues.
2 participants
@WilliamAntonRohm @mairaw