Skip to content

SignedCMS.ComputeSignature change for .NET Core #3866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 12, 2020
Merged

SignedCMS.ComputeSignature change for .NET Core #3866

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bddc6a9
Fixes #3456
gewarren Feb 10, 2020
8ef2247
Add remark and update parameter description
gewarren Feb 10, 2020
de12d3f
Update xml/System.Security.Cryptography.Pkcs/SignedCms.xml
gewarren Feb 11, 2020
2e090ca
Fix spacing
gewarren Feb 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions xml/System.Security.Cryptography.Pkcs/SignedCms.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -655,7 +655,7 @@ The following permissions are required to access the signature key:
</Parameters>
<Docs>
<param name="signer">A <see cref="T:System.Security.Cryptography.Pkcs.CmsSigner" /> object that represents the signer.</param>
<summary>The <see cref="M:System.Security.Cryptography.Pkcs.SignedCms.ComputeSignature(System.Security.Cryptography.Pkcs.CmsSigner)" /> method creates a signature using the specified signer and adds the signature to the CMS/PKCS #7 message.</summary>
<summary>Creates a signature using the specified signer and adds the signature to the CMS/PKCS #7 message.</summary>
<remarks>
<format type="text/markdown"><![CDATA[

Expand Down Expand Up @@ -720,12 +720,14 @@ The following permissions are required to access the signature key:
</Parameters>
<Docs>
<param name="signer">A <see cref="T:System.Security.Cryptography.Pkcs.CmsSigner" /> object that represents the signer.</param>
<param name="silent">This parameter is not used. </param>
<param name="silent">.NET Core only: <see langword="true" to to request opening keys with PIN prompts disabled, where supported; otherwise <see langword="false">. In .NET Framework, this parameter is not used and a PIN prompt is always shown, if required.</param>
<summary>Creates a signature using the specified signer and adds the signature to the CMS/PKCS #7 message. </summary>
<remarks>
<format type="text/markdown"><![CDATA[

## Remarks
## Remarks

.NET Core only: The `silent `parameter has no effect if the <xref:System.Security.Cryptography.Pkcs.CmsSigner.PrivateKey?displayProperty=nameWithType> value is not null. The provided value controls whether or not computing the signature shows a PIN prompt. Even when the <xref:System.Security.Cryptography.Pkcs.CmsSigner.PrivateKey> property is null and the `silent` parameter is set to `true`, some combinations of operating system and signer options can still result in a PIN prompt.

## .NET Framework Security
The following permissions are required to display the user interface:
Expand Down