Skip to content

Conversation

gewarren
Copy link
Contributor

Fixes #3456

@dotnet-bot dotnet-bot added this to the February 2020 milestone Feb 10, 2020
@gewarren
Copy link
Contributor Author

Do we need to add in this info?

"It does look like it's only respected when the Windows PAL is used, so Windows OS without using options that force it into the managed PAL (like providing your own private key instance)."

@gewarren gewarren requested a review from bartonjs February 10, 2020 21:20
@bartonjs
Copy link
Member

Maybe the .NET Core value should be something like

true to request opening keys with PIN prompts disabled, where supported; otherwise, false. Then maybe a remark like

The silent parameter has no effect if the CmsSigner.PrivateKey value is not null; whether or not computing the signature will prompt is controlled by the provided value. Even when the PrivateKey property is null, some combinations of Operating System and signer options can result in a PIN prompt even when the silent parameter is set to true.

@gewarren
Copy link
Contributor Author

Close/reopen

Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gewarren gewarren merged commit 19d059b into master Feb 12, 2020
@gewarren gewarren deleted the gewarren-patch-1 branch February 12, 2020 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SignedCms.ComputeSignature changes
5 participants