Fix warning CA2002: Do not lock on objects with weak identity#13
Merged
gabikliot merged 1 commit intodotnet:masterfrom Jan 26, 2015
zerhacken:dev/fix-storage-weak-identity-lock
Merged
Fix warning CA2002: Do not lock on objects with weak identity#13gabikliot merged 1 commit intodotnet:masterfrom zerhacken:dev/fix-storage-weak-identity-lock
gabikliot merged 1 commit intodotnet:masterfrom
zerhacken:dev/fix-storage-weak-identity-lock
Conversation
Contributor
|
Hi Thank you for this fix. 2 comments:
|
Contributor
Author
I will squash the commits on dev/fix-storage-weak-identity-lock and provide a decent commit message. |
Contributor
Author
|
Looks like the build failed "java.io.IOException: An existing connection was forcibly closed by the remote host" |
Lock on a private object which only instance is knowledgeable about.
gabikliot
added a commit
that referenced
this pull request
Jan 26, 2015
Fix warning CA2002: Do not lock on objects with weak identity
sergeybykov
added a commit
that referenced
this pull request
Feb 10, 2017
ReubenBond
pushed a commit
to ReubenBond/orleans
that referenced
this pull request
Apr 6, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes warning CA2002. HierarchicalKeyStore extends
MarshalByRefObject which allows code code running in one AppDomain
to lock on an object in another AppDomain. Fix is to lock on a private
object which only HierarchicalKeyStore is knowledgeable about.