Add waitForAsyncOperations LSP request #79669
Conversation
|
@JoeRobich @dibarbet for review. |
|
Are we unable to use our existing watcher setup for integration tests here? |
|
I am unaware of what the watcher setup is. Is there any example you can point me at? |
|
@jasonmalinowski did you have any blocking concerns about this PR? |
|
It was suggested offline that I rework these notifications to be requests instead along with the following types/patterns/existing PRs https://github.com/dotnet/vscode-csharp/pull/6544/files Basically the LSP client should be able to call a method which essentially just waits on an IAsynchronousOperationWaiter for a particular feature, "returning" an empty value to the caller when the operation is done. |
…ild-notifications
…to lsps-design-time-build-notifications
|
Now incorporating work from #70359 and dotnet/vscode-csharp#6544 |
|
|
||
| [ImportingConstructor] | ||
| [Obsolete(MefConstruction.ImportingConstructorMessage, error: true)] | ||
| public WaitForAsyncOperationsHandler(AsynchronousOperationListenerProvider listenerProvider) |
There was a problem hiding this comment.
I will allow the next round of IDE auto-fixers to address this. Thanks
RikkiGibson
changed the title
These new notifications support integration testing restore for FBPs, and, eventually could allow us to have more visibility for users when design-time builds are happening on the vscode side.
Prerequisite for dotnet/vscode-csharp#8470