Add integration test for restore of file-based programs #8470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RikkiGibson
commented
Jul 29, 2025
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
I gotta say, I am not the most thrilled about certain aspects of javascript debugging. (when the "current statement" being debugged is a whole screenful and then some..) 
|
Depending on what you are debugging that may be expected or not. If you are debugging the extension code running in the tests, there should be source maps which let you step through the typescript. But if you're debugging VSCode itself, unfortunately thats what we have without a lot more setup. |
…b.com/dotnet/vscode-csharp into dev/rigibson/integration-test-restore
|
@dibarbet pointed out the integration test may be failing because the waiter needs to be explicitly enabled in this context. The test does pass locally, but, maybe lack of the env var was causing a problem in CI. We will find out. It looks like it would also be an option to add a command line argument to LanguageServer and call |
|
This is the problem This probably means an SDK update is needed. |
|
@davidwengier just curious, have you seen this particular failure in razor integration tests before? If you have no clue that's OK, just looking for shortcuts in the investigation.. All that "failed to connect to the bus" stuff looks particularly suspicious to me |
this is relatively normal and generally not indicative of the failure cause. most of the times I'd recommend looking at the actual c#/razor logs in the attached artifacts. the vscode process output is only occasionally useful |
I'm continuing to see this as well as quite a few failing integration tests on re-run. Maybe we really are getting a Free Reproducer Of The Issue for our trouble. I won't be able to investigate in detail today, but, hopefully tomorrow. |
|
I haven't seen that error before today, but the same thing has just been reported on another Razor VS Code issue: microsoft/vscode-dotnettools#2229 I am planning to investigate that today, as this could be a cohosting issue unrelated to file-based programs (we do various crimes with generated document trees) though the fact that the exception originates from the CLaSP queue, and your test isn't modifying a Razor document, it seems relatively unlikely. EDIT: I just re-read where you tagged me, and to be clear, in this comment I'm talking about the "Syntax tree doesn't belong to the underlying 'Compilation'." exception, not the failing Razor tests you linked to. Sorry, too early for proper comprehension :) |
…ation-test-restore
RikkiGibson
commented
Oct 29, 2025
|
|
||
| const doRunSuite = process.env.RoslynSkipTestFileBasedPrograms !== 'true'; | ||
| console.log(`process.env.RoslynSkipTestFileBasedPrograms: ${process.env.RoslynSkipTestFileBasedPrograms}`); | ||
| const doRunSuite = process.env['ROSLYN_SKIP_TEST_FILE_BASED_PROGRAMS'] !== 'true'; |
There was a problem hiding this comment.
System and user-defined variables (except secret variables) also get injected as environment variables for your platform. When variables convert into environment variables, variable names become uppercase, and periods turn into underscores. For example, the variable name any.variable becomes the variable name $ANY_VARIABLE.
Linux env vars are case sensitive, so, the env. lookup is case sensitive. Since we were not using an uppercase name to access the env var, we weren't seeing it in the test.
Figuring this out took an unreasonable amount of time.
Maybe the remaining failing legs are using too old of an SDK? They may need to also have the env var added. |
|
@JoeRobich @dibarbet This is ready for review |
JoeRobich
approved these changes
Nov 3, 2025
dibarbet
approved these changes
Nov 3, 2025
|
|
||
| const doRunSuite = process.env['ROSLYN_SKIP_TEST_FILE_BASED_PROGRAMS'] !== 'true'; | ||
| console.log(`process.env.ROSLYN_SKIP_TEST_FILE_BASED_PROGRAMS: ${process.env.ROSLYN_SKIP_TEST_FILE_BASED_PROGRAMS}`); | ||
| console.log(`doRunSuite: ${doRunSuite}`); |
There was a problem hiding this comment.
consider extracting all this to a helper function similar to
| let exports: CSharpExtensionExports; | ||
|
|
||
| beforeAll(async () => { | ||
| process.env.RoslynWaiterEnabled = 'true'; |
There was a problem hiding this comment.
Thinking it would be reasonable to set this for all Roslyn integration test runs, even if we don't use it yet.
e.g.
I can look at that in a followup though myself.
| }); | ||
|
|
||
| test('Inserting package directive triggers a restore', async () => { | ||
| await sleep(1); |
There was a problem hiding this comment.
This was taken from here:
I didn't see a clear sign that it is needed, though, so I'll try deleting it here
There was a problem hiding this comment.
Oh I added it 😆 I suspect it was in there as I was debugging and I just forgot to remove it.
| displayName: Test Windows | ||
| dependsOn: [] | ||
| variables: | ||
| ROSLYN_SKIP_TEST_FILE_BASED_PROGRAMS: 'true' |
There was a problem hiding this comment.
I assume we can enable the tests for windows/mac when we upgrade them to running on .NET 10?
| @@ -0,0 +1,4 @@ | |||
|
|
|||
| using Newton; | |||
There was a problem hiding this comment.
Instead of having this be in the file by default, should we insert it during the test? That way we can re-use the same base test file if we need to for other tests?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on changes in dotnet/roslyn#79669