Skip to content

Add integration test for restore of file-based programs #8470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 43 commits into from
Nov 4, 2025
Merged

Add integration test for restore of file-based programs #8470

Changes from 1 commit
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
bd19287
add test resource
RikkiGibson Jul 29, 2025
1305e21
WIP: Integration test for file-based programs restore scenario
RikkiGibson Jul 29, 2025
e0dea11
Merge remote-tracking branch 'origin/main' into dev/rigibson/integrat…
RikkiGibson Jul 31, 2025
3458d52
add D.B.props
RikkiGibson Jul 31, 2025
d4b5997
cleanup
RikkiGibson Jul 31, 2025
f9be157
inspect details of notifications from server
RikkiGibson Jul 31, 2025
5fd1d9c
use 'waitForAllAsyncOperationsAsync'
RikkiGibson Aug 7, 2025
45e4d45
simplify
RikkiGibson Aug 7, 2025
fa315bc
fix lint errors
RikkiGibson Aug 7, 2025
02e435c
Merge remote-tracking branch 'origin/main' into dev/rigibson/integrat…
RikkiGibson Aug 7, 2025
0ef2931
WIP: bump roslyn version
RikkiGibson Aug 10, 2025
5a32bb2
rekick CI after adding package to feeds
RikkiGibson Aug 10, 2025
ad92e62
fix lint errors
RikkiGibson Aug 10, 2025
2239641
Merge branch 'dev/rigibson/integration-test-restore' of https://githu…
RikkiGibson Aug 10, 2025
e4e236a
Merge remote-tracking branch 'origin/main' into dev/rigibson/integrat…
RikkiGibson Aug 12, 2025
2fd2774
enable waiter in restore tests via env var
RikkiGibson Aug 12, 2025
3beee8e
I installed eslint finally
RikkiGibson Aug 12, 2025
3054919
condition test on new enough sdk
RikkiGibson Aug 12, 2025
94a2175
includePreviewVersions
RikkiGibson Aug 12, 2025
386f63e
use exact version
RikkiGibson Aug 12, 2025
f31eeaa
remove unnecessary(?) flag
RikkiGibson Aug 12, 2025
4fb723a
dot dot dot...
RikkiGibson Aug 12, 2025
b9637ba
update package name
RikkiGibson Aug 12, 2025
2493d9d
Explicitly get ubuntu noble numbat containers
RikkiGibson Aug 12, 2025
eb24923
Merge remote-tracking branch 'upstream/main' into dev/rigibson/integr…
RikkiGibson Oct 28, 2025
3c5d899
fix yml. fix skip test variable.
RikkiGibson Oct 28, 2025
77781dc
fix container name
RikkiGibson Oct 28, 2025
cc3d74f
fix for I bet the last time
RikkiGibson Oct 28, 2025
9d742a3
Move env var in pipeline
RikkiGibson Oct 28, 2025
7cf3de2
try to inspect what is happening in CI
RikkiGibson Oct 28, 2025
78c2213
try different name
RikkiGibson Oct 28, 2025
3e60d31
use template parameter
RikkiGibson Oct 28, 2025
c2f35aa
fix name
RikkiGibson Oct 28, 2025
dd46cce
try to deal with azdo env var weirdness
RikkiGibson Oct 28, 2025
b78119a
finish rename
RikkiGibson Oct 28, 2025
0baa5ab
rename test file
RikkiGibson Oct 28, 2025
885011d
More skips
RikkiGibson Oct 29, 2025
a56489b
Merge branch 'main' into dev/rigibson/integration-test-restore
RikkiGibson Oct 29, 2025
c030821
Merge branch 'main' into dev/rigibson/integration-test-restore
RikkiGibson Oct 30, 2025
b9eb6a9
try to remove sleep(1)
RikkiGibson Nov 3, 2025
3925c0c
edit scripts/app1.cs
RikkiGibson Nov 4, 2025
293cf59
extract describeIf helper
RikkiGibson Nov 4, 2025
c7ceaf1
Merge branch 'main' into dev/rigibson/integration-test-restore
RikkiGibson Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...egrationTests/restore.integration.test.ts → ...sts/fileBasedPrograms.integration.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ import {
import { describe, beforeAll, beforeEach, afterAll, test, expect, afterEach } from '@jest/globals';
import { CSharpExtensionExports } from '../../../src/csharpExtensionExports';

const doRunSuite = process.env.RoslynSkipTestFileBasedPrograms !== 'true';
console.log(`process.env.RoslynSkipTestFileBasedPrograms: ${process.env.RoslynSkipTestFileBasedPrograms}`);
const doRunSuite = process.env['ROSLYN_SKIP_TEST_FILE_BASED_PROGRAMS'] !== 'true';
Copy link
Member Author

@RikkiGibson RikkiGibson Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://learn.microsoft.com/en-us/azure/devops/pipelines/process/variables?view=azure-devops&tabs=yaml%2Cbatch#environment-variables

System and user-defined variables (except secret variables) also get injected as environment variables for your platform. When variables convert into environment variables, variable names become uppercase, and periods turn into underscores. For example, the variable name any.variable becomes the variable name $ANY_VARIABLE.

Linux env vars are case sensitive, so, the env. lookup is case sensitive. Since we were not using an uppercase name to access the env var, we weren't seeing it in the test.

Figuring this out took an unreasonable amount of time.

console.log(`process.env.ROSLYN_SKIP_TEST_FILE_BASED_PROGRAMS: ${process.env.ROSLYN_SKIP_TEST_FILE_BASED_PROGRAMS}`);
console.log(`doRunSuite: ${doRunSuite}`);
Copy link
Member

@dibarbet dibarbet Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider extracting all this to a helper function similar to

vscode-csharp/test/lsptoolshost/integrationTests/integrationHelpers.ts

Line 272 in 65e5e08

export const describeIfCSharp = describeIf(!usingDevKit());

(doRunSuite ? describe : describe.skip)(`Restore Tests`, () => {
(doRunSuite ? describe : describe.skip)(`File-based Programs Tests`, () => {
let exports: CSharpExtensionExports;

beforeAll(async () => {
Expand Down
Loading