Skip to content

Avoid some allocations in BitVector256 #120427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Avoid some allocations in BitVector256 #120427

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions src/libraries/System.Private.CoreLib/src/System/SearchValues/BitVector256.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,28 +50,32 @@ private readonly bool ContainsUnchecked(int b)

public readonly char[] GetCharValues()
{
var chars = new List<char>();
Span<char> chars = stackalloc char[256];
int size = 0;
for (int i = 0; i < 256; i++)
{
if (ContainsUnchecked(i))
{
chars.Add((char)i);
chars[size] = (char)i;
size++;
}
}
return chars.ToArray();
return chars.Slice(0, size).ToArray();
}

public readonly byte[] GetByteValues()
{
var bytes = new List<byte>();
Span<byte> bytes = stackalloc byte[256];
int size = 0;
for (int i = 0; i < 256; i++)
{
if (ContainsUnchecked(i))
{
bytes.Add((byte)i);
bytes[size] = (byte)i;
size++;
}
}
return bytes.ToArray();
return bytes.Slice(0, size).ToArray();
}
}
}
Loading