Skip to content

Clean up illink compat suppressions by making internal types non-public #123048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Clean up illink compat suppressions by making internal types non-public #123048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4bf69cc
Initial plan
Copilot Jan 9, 2026
cc3a918
Make extension classes and BCL/Driver internal, remove suppressions
Copilot Jan 9, 2026
c33fb1a
Make Step implementation classes internal, remove suppressions
Copilot Jan 9, 2026
a7e8aad
Make additional helper classes internal, remove suppressions
Copilot Jan 9, 2026
5354a36
Revert Driver class to public to fix test build break
Copilot Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
176 changes: 0 additions & 176 deletions src/tools/illink/src/linker/CompatibilitySuppressions.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,46 +129,6 @@
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:ILLink.Shared.TypeSystemProxy.WellKnownTypeExtensions</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.AssemblyDefinitionExtensions</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.AssemblyResolver</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.AssemblyRootMode</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.AttributeInfo</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.BannedApiExtensions</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.BCL</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.CodeOptimizations</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.CodeOptimizationsSettings</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.ConsoleLogger</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.CustomAttributeArgumentExtensions</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.CustomAttributeSource</Target>
Expand Down Expand Up @@ -245,10 +205,6 @@
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.EmbeddedXmlInfo</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.FeatureSettings</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.IDependencyRecorder</Target>
Expand All @@ -261,10 +217,6 @@
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.InterfaceImplementor</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.InternalErrorException</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.ITryResolveMetadata</Target>
Expand All @@ -277,10 +229,6 @@
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.KnownMembers</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.LinkerFatalErrorException</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.LinkerILProcessor</Target>
Expand All @@ -293,10 +241,6 @@
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.MemberActionStore</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.MemberReferenceExtensions</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.MetadataTrimming</Target>
Expand All @@ -305,18 +249,10 @@
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.MethodBodyScanner</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.MethodDefinitionExtensions</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.MethodIL</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.MethodReferenceExtensions</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.ModuleDefinitionExtensions</Target>
Expand Down Expand Up @@ -353,62 +289,22 @@
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.SerializerKind</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.Steps.AddBypassNGenStep</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.Steps.AllowedAssemblies</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.Steps.BodySubstituterStep</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.Steps.BodySubstitutionParser</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.Steps.CheckSuppressionsDispatcher</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.Steps.CheckSuppressionsStep</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.Steps.CleanStep</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.Steps.CodeRewriterStep</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.Steps.DescriptorMarker</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.Steps.DiscoverOperatorsHandler</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.Steps.DiscoverSerializationHandler</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.Steps.LinkAttributesParser</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.Steps.LinkAttributesStep</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.Steps.MarkExportedTypesTarget</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.Steps.MarkScopeStack</Target>
Expand All @@ -421,70 +317,10 @@
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.Steps.MarkStepContext</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.Steps.OutputStep</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.Steps.OutputWarningSuppressions</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.Steps.ProcessLinkerXmlBase</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.Steps.ProcessLinkerXmlStepBase</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.Steps.ProcessReferencesStep</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.Steps.ProcessWarningsStep</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.Steps.ReflectionBlockedStep</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.Steps.RegenerateGuidStep</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.Steps.RemoveResourcesStep</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.Steps.RemoveSecurity</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.Steps.ResolveFromXmlStep</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.Steps.RootAssemblyInput</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.Steps.SealerStep</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.Steps.SweepStep</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.Steps.UnreachableBlocksOptimizer</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.Steps.ValidateVirtualMethodAnnotationsStep</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.SubstitutionInfo</Target>
Expand All @@ -493,18 +329,10 @@
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.SuppressMessageInfo</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.TargetRuntimeVersion</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.Tracer</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.TypeDefinitionExtensions</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.TypeMapInfo</Target>
Expand All @@ -521,10 +349,6 @@
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.UnconditionalSuppressMessageAttributeState</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.UnintializedContextFactory</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Mono.Linker.WarningSuppressionWriter</Target>
Expand Down
2 changes: 1 addition & 1 deletion src/tools/illink/src/linker/Linker.Steps/AddBypassNGenStep.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
namespace Mono.Linker.Steps
{

public class AddBypassNGenStep : BaseStep
internal class AddBypassNGenStep : BaseStep
{

AssemblyDefinition? coreLibAssembly;
Expand Down
2 changes: 1 addition & 1 deletion src/tools/illink/src/linker/Linker.Steps/BodySubstituterStep.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

namespace Mono.Linker.Steps
{
public class BodySubstituterStep : ProcessLinkerXmlStepBase
internal class BodySubstituterStep : ProcessLinkerXmlStepBase
{
public BodySubstituterStep(Stream documentStream, string xmlDocumentLocation)
: base(documentStream, xmlDocumentLocation)
Expand Down
2 changes: 1 addition & 1 deletion src/tools/illink/src/linker/Linker.Steps/CheckSuppressionsDispatcher.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

namespace Mono.Linker.Steps
{
public class CheckSuppressionsDispatcher : SubStepsDispatcher
internal class CheckSuppressionsDispatcher : SubStepsDispatcher
{
public CheckSuppressionsDispatcher() : base(new List<ISubStep> { new CheckSuppressionsStep() })
{
Expand Down
2 changes: 1 addition & 1 deletion src/tools/illink/src/linker/Linker.Steps/CheckSuppressionsStep.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

namespace Mono.Linker.Steps
{
public class CheckSuppressionsStep : BaseSubStep
internal class CheckSuppressionsStep : BaseSubStep
{
public override SubStepTargets Targets
{
Expand Down
2 changes: 1 addition & 1 deletion src/tools/illink/src/linker/Linker.Steps/CleanStep.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
namespace Mono.Linker.Steps
{

public class CleanStep : BaseStep
internal class CleanStep : BaseStep
{

protected override void ProcessAssembly(AssemblyDefinition assembly)
Expand Down
2 changes: 1 addition & 1 deletion src/tools/illink/src/linker/Linker.Steps/CodeRewriterStep.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

namespace Mono.Linker.Steps
{
public class CodeRewriterStep : BaseStep
internal class CodeRewriterStep : BaseStep
{
AssemblyDefinition? assembly;
AssemblyDefinition Assembly
Expand Down
2 changes: 1 addition & 1 deletion src/tools/illink/src/linker/Linker.Steps/DiscoverCustomOperatorsHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

namespace Mono.Linker.Steps
{
public class DiscoverOperatorsHandler : IMarkHandler
internal class DiscoverOperatorsHandler : IMarkHandler
{
LinkContext? _context;
LinkContext Context
Expand Down
2 changes: 1 addition & 1 deletion src/tools/illink/src/linker/Linker.Steps/DiscoverSerializationHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ namespace Mono.Linker.Steps
// of xamarin-android. It is not meant to be complete. Unlike xamarin-andorid:
// - this will only discover attributed types that are marked
// - this will discover types in non-"link" assemblies as well
public class DiscoverSerializationHandler : IMarkHandler
internal class DiscoverSerializationHandler : IMarkHandler
{
LinkContext? _context;
LinkContext Context
Expand Down
2 changes: 1 addition & 1 deletion src/tools/illink/src/linker/Linker.Steps/LinkAttributesStep.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

namespace Mono.Linker.Steps
{
public class LinkAttributesStep : ProcessLinkerXmlStepBase
internal class LinkAttributesStep : ProcessLinkerXmlStepBase
{
public LinkAttributesStep(Stream documentStream, string xmlDocumentLocation)
: base(documentStream, xmlDocumentLocation)
Expand Down
2 changes: 1 addition & 1 deletion src/tools/illink/src/linker/Linker.Steps/MarkExportedTypesTargetStep.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

namespace Mono.Linker.Steps
{
public static class MarkExportedTypesTarget
internal static class MarkExportedTypesTarget
{
public static void ProcessAssembly(AssemblyDefinition assembly, LinkContext context)
{
Expand Down
2 changes: 1 addition & 1 deletion src/tools/illink/src/linker/Linker.Steps/OutputStep.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
namespace Mono.Linker.Steps
{

public class OutputStep : BaseStep
internal class OutputStep : BaseStep
{
readonly List<string> assembliesWritten;

Expand Down
2 changes: 1 addition & 1 deletion src/tools/illink/src/linker/Linker.Steps/OutputWarningSuppressions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

namespace Mono.Linker.Steps
{
public class OutputWarningSuppressions : BaseStep
internal class OutputWarningSuppressions : BaseStep
{
protected override bool ConditionToProcess()
{
Expand Down
2 changes: 1 addition & 1 deletion src/tools/illink/src/linker/Linker.Steps/ProcessLinkerXmlStepBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

namespace Mono.Linker.Steps
{
public class ProcessLinkerXmlStepBase : BaseStep
internal class ProcessLinkerXmlStepBase : BaseStep
{
protected readonly string _xmlDocumentLocation;
protected readonly Stream _documentStream;
Expand Down
2 changes: 1 addition & 1 deletion src/tools/illink/src/linker/Linker.Steps/ProcessReferencesStep.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

namespace Mono.Linker.Steps
{
public class ProcessReferencesStep : BaseStep
internal class ProcessReferencesStep : BaseStep
{
protected override void Process()
{
Expand Down
Loading
Loading