Skip to content

Conversation

WilliamAntonRohm
Copy link
Contributor

@@ -3,21 +3,23 @@

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WilliamAntonRohm I've removed the changes here because they depend on culture, so we shouldn't touch those. Make sure that the changes in dotnet-api-docs are also reverted.

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @WilliamAntonRohm. The changes overall looked great! I've made a few fixes unrelated to your changes that were related to our C# coding guidelines (https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/coding-style.md), which I've noticed were not being followed here.
Also, I had to undo the changes to a few samples that depended on the current culture, which made them have different results when run under the try .net engine (you can test them at https://try.dot.net/).
So whatever changes you made to make those samples interactive will have to be removed and include notes reviewed to see if we still have right ones.

@mairaw mairaw merged commit 62a7779 into dotnet:master Aug 9, 2019
@WilliamAntonRohm WilliamAntonRohm deleted the system-string branch August 9, 2019 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants