-
Notifications
You must be signed in to change notification settings - Fork 1.6k
adding Try .NET for System.String.* #2971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Triggering new build |
dotnet/samples#1149 was merged now. @WilliamAntonRohm please see my merge comments there for some changes you'll have to make. |
@mairaw -- Maira, I've removed "-interactive" for the 6 sample files where you undid changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall @WilliamAntonRohm, but we need to fix a few things before merging.
@mairaw -- thank you for your review. I'll make these changes shortly. |
@mairaw -- I've addressed your review comments in String.xml here and in the sample files PR |
I kicked off a new build for the master branch which will allow me to pull the latest samples into this PR. I'll close and reopen this PR when that happens. |
Starting new build... |
Build has finished. Have you tested all your changes already @WilliamAntonRohm? |
@mairaw -- thank you for your review. I am double-checking all the samples under these 10 member groups/members. |
Sounds good. I'm going through them as well to double check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finished my new review. Please take a look.
@WilliamAntonRohm any updates here? |
@mairaw -- I have been through Compare and updated the samples to match, adding three new interactive samples (comp3.cs [twice] and comp4.cs); see my note above regarding remarks.cs. Contains is good to go. IndexOf has been checked & updated. |
@WilliamAntonRohm I don't see any updates from today. Also, look at my comments for dotnet/samples#1192 and see if you need to make any changes based on the changes I've made on top of that. Thanks! |
@mairaw -- I am hoping this build will succeed by morning. Thank you for your close review of the latest samples, and for showing me their preferred formatting -- I'm checking the other post-interactivated samples. |
I didn't include that as part of the task description, so I'm just doing as I review the work. |
@mairaw -- Maira, I believe this new String.xml is ready to go live. Thank you for your patience with my learning curve -- I anticipate the next ones (regex) will be much smoother. |
We have new merge conflicts 😢 |
@mairaw -- dang! I'm unable to see the conflicts in this PR or its replacement #3070, as the "Resolve conflicts" button is grayed-out, presumably a byproduct of my permissions level; I am likewise unable to assign an owner or reviewer. If you could send me a raw text file of the conflicts I can re-create my additions. |
per https://dev.azure.com/mseng/TechnicalContent/_workitems/edit/1558837/
Sample code PR is dotnet/samples#1149
This PR includes the following member groups and members: