Fix crash in VSTestForwardingApp when trace is enabled with empty args#53307
Draft
Evangelink wants to merge 1 commit intomainfrom
Draft
Fix crash in VSTestForwardingApp when trace is enabled with empty args#53307Evangelink wants to merge 1 commit intomainfrom
Evangelink wants to merge 1 commit intomainfrom
Conversation
Aggregate() throws InvalidOperationException on an empty sequence. If argsToForward is non-null but empty and VSTest trace logging is enabled, the constructor would crash. Replace with string.Join which handles empty sequences safely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a potential crash in
VSTestForwardingAppconstructor when VSTest trace logging is enabled andargsToForwardis an empty sequence.Problem
The trace logging line uses
Aggregate()to join args:Aggregate()throwsInvalidOperationExceptionon an empty sequence. IfargsToForwardis non-null but empty andVSTEST_TRACEis enabled, the constructor crashes before the forwarding app can even start.Fix
Replace
Aggregatewithstring.Join, which handles empty sequences safely and produces equivalent output.Changes
src/Cli/dotnet/Commands/Test/VSTest/VSTestForwardingApp.cs