-
-
Notifications
You must be signed in to change notification settings - Fork 364
Should support IDynamicObject in IEditorItem CanWrite #4998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Should support IDynamicObject in IEditorItem CanWrite method since DynamicColumnObject doesn't inherit from DynamicObject
This reverts commit f7f0607.
Reviewer's Guide by SourceryThis PR updates the Class diagram showing the updated type relationship for DynamicObject supportclassDiagram
class DynamicObject {
}
class IDynamicObject {
<<interface>>
}
class DynamicColumnObject {
}
DynamicObject ..|> IDynamicObject
DynamicColumnObject ..|> IDynamicObject
note for IDynamicObject "New interface check replaces DynamicObject inheritance check"
note for DynamicColumnObject "Example class implementing IDynamicObject"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Thanks for your PR, @tiansfather. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tiansfather - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please complete the PR template fully, including regression status, risk assessment, and verification details. This helps reviewers better understand the context and impact of the change.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4998 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 630 630
Lines 28105 28105
Branches 4030 4030
=========================================
Hits 28105 28105 ☔ View full report in Codecov by Sentry. |
|
@tiansfather 感谢大佬提交 PR, 请补充 Issue 写明示例,我需要了解代码运行逻辑,方便以后维护 |
|
@tiansfather 动态类型根据实现不同。这里是很难实现 |
|
恩,那没事,这个pr先撤回 |


{PR title}
Summary of the changes (Less than 80 chars)
比如DynamicColumnObject不继承DynamicObject,只是实现了IDynamicObject接口,故在方法中需要调整判断方式
Description
fixes #{bug number} (in this specific format)
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Bug Fixes: